From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Piggin Subject: Re: [PATCH 2/2] AFS: Implement shared-writable mmap Date: Wed, 16 May 2007 17:17:09 +1000 Message-ID: <464AAFF5.2040308@yahoo.com.au> References: <20070515155224.29345.22719.stgit@warthog.cambridge.redhat.com> <20070515155231.29345.6212.stgit@warthog.cambridge.redhat.com> <20070516071054.GA14222@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Cc: David Howells , akpm@osdl.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, dchinner@sgi.com To: Christoph Hellwig Return-path: Received: from smtp107.mail.mud.yahoo.com ([209.191.85.217]:42709 "HELO smtp107.mail.mud.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1755315AbXEPHRV (ORCPT ); Wed, 16 May 2007 03:17:21 -0400 In-Reply-To: <20070516071054.GA14222@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Christoph Hellwig wrote: > On Tue, May 15, 2007 at 04:52:31PM +0100, David Howells wrote: > >>+int afs_page_mkwrite(struct vm_area_struct *vma, struct page *page) >>+{ >>+ struct afs_vnode *vnode = AFS_FS_I(vma->vm_file->f_mapping->host); >>+ struct key *key = vma->vm_file->private_data; >>+ int ret; >>+ >>+ _enter("{{%x:%u},%x},{%lx}", >>+ vnode->fid.vid, vnode->fid.vnode, key_serial(key), page->index); >>+ >>+ lock_page(page); >>+ ret = afs_prepare_write(vma->vm_file, page, 0, 0); >>+ unlock_page(page); >>+ >>+ _leave(" = %d", ret); >>+ return ret; >>+} > > > It looks like you really want Dave's generic page_mkwrite. Is that appropriate for a non buffer based filesystem? > And we should > really get that one merged for 2.6.22. Dave asked me about that the other day (in relation to the ->fault ops)... I have no problem merging it for 2.6.22 and rebasing my patches on top. -- SUSE Labs, Novell Inc.