From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Florian D." Subject: Re: [ANNOUNCE] Btrfs: a copy on write, snapshotting FS Date: Fri, 15 Jun 2007 22:46:04 +0200 Message-ID: <4672FA8C.50309@gmail.com> References: <20070612161029.GB28279@think.oraclecorp.com> <467188F6.7020002@gmail.com> <20070614191331.GE2061@think.oraclecorp.com> <4672E3B6.1030000@gmail.com> <20070615191153.GU2061@think.oraclecorp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org To: Chris Mason Return-path: Received: from mail.t-c-c.at ([82.150.200.3]:60469 "HELO mail.t-c-c.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1754258AbXFOUqX (ORCPT ); Fri, 15 Jun 2007 16:46:23 -0400 In-Reply-To: <20070615191153.GU2061@think.oraclecorp.com> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Chris Mason wrote: >> # umount /mnt/temp/ >> >> [ 457.980372] ------------[ cut here ]------------ >> [ 457.980377] kernel BUG at fs/buffer.c:2644! > > Whoops. Please try this: > > diff -r 38b36aaaa731 disk-io.c > --- a/disk-io.c Fri Jun 15 13:50:20 2007 -0400 > +++ b/disk-io.c Fri Jun 15 15:12:26 2007 -0400 > @@ -541,6 +541,7 @@ int write_ctree_super(struct btrfs_trans > else > ret = submit_bh(WRITE, bh); > if (ret == -EOPNOTSUPP) { > + lock_buffer(bh); > set_buffer_uptodate(bh); > root->fs_info->do_barriers = 0; > ret = submit_bh(WRITE, bh); > sorry, with the patch applied: [ 147.475077] BUG: at /home/florian/system/btrfs_test/btrfs-0.2/disk-io.c:534 write_ctree_super() [ 147.475082] [ 147.475083] Call Trace: [ 147.475096] [] :btrfs:write_ctree_super+0x70/0x140 [ 147.475106] [] :btrfs:btrfs_commit_transaction+0x43e/0x5c0 [ 147.475112] [] __writeback_single_inode+0x34f/0x361 [ 147.475121] [] :btrfs:btrfs_commit_transaction+0x565/0x5c0 [ 147.475126] [] autoremove_wake_function+0x0/0x2e [ 147.475136] [] :btrfs:close_ctree+0x4e/0x191 [ 147.475141] [] dispose_list+0xad/0xc9 [ 147.475146] [] invalidate_inodes+0xc3/0xd5 [ 147.475155] [] :btrfs:btrfs_put_super+0x10/0x31 [ 147.475159] [] generic_shutdown_super+0x5b/0xd2 [ 147.475163] [] kill_block_super+0x26/0x3b [ 147.475167] [] deactivate_super+0x3d/0x55 [ 147.475172] [] sys_umount+0x1ca/0x1f1 [ 147.475177] [] sys_newstat+0x19/0x31 [ 147.475184] [] system_call+0x7e/0x83 [ 147.475188] [ 147.476020] BUG: at /home/florian/system/btrfs_test/btrfs-0.2/disk-io.c:534 write_ctree_super() [ 147.476023] [ 147.476024] Call Trace: [ 147.476033] [] :btrfs:write_ctree_super+0x70/0x140 [ 147.476042] [] :btrfs:btrfs_commit_transaction+0x43e/0x5c0 [ 147.476048] [] __writeback_single_inode+0x34f/0x361 [ 147.476057] [] :btrfs:btrfs_commit_transaction+0x565/0x5c0 [ 147.476061] [] autoremove_wake_function+0x0/0x2e [ 147.476066] [] mutex_lock+0xd/0x1d [ 147.476075] [] :btrfs:close_ctree+0x66/0x191 [ 147.476080] [] dispose_list+0xad/0xc9 [ 147.476085] [] invalidate_inodes+0xc3/0xd5 [ 147.476096] [] :btrfs:btrfs_put_super+0x10/0x31 [ 147.476100] [] generic_shutdown_super+0x5b/0xd2 [ 147.476104] [] kill_block_super+0x26/0x3b [ 147.476108] [] deactivate_super+0x3d/0x55 [ 147.476112] [] sys_umount+0x1ca/0x1f1 [ 147.476118] [] sys_newstat+0x19/0x31 [ 147.476124] [] system_call+0x7e/0x83 [ 147.476128] [ 147.482579] BUG: at /home/florian/system/btrfs_test/btrfs-0.2/disk-io.c:534 write_ctree_super() [ 147.482582] [ 147.482583] Call Trace: [ 147.482592] [] :btrfs:write_ctree_super+0x70/0x140 [ 147.482601] [] :btrfs:close_ctree+0x82/0x191 [ 147.482605] [] dispose_list+0xad/0xc9 [ 147.482611] [] invalidate_inodes+0xc3/0xd5 [ 147.482619] [] :btrfs:btrfs_put_super+0x10/0x31 [ 147.482623] [] generic_shutdown_super+0x5b/0xd2 [ 147.482627] [] kill_block_super+0x26/0x3b [ 147.482631] [] deactivate_super+0x3d/0x55 [ 147.482636] [] sys_umount+0x1ca/0x1f1 [ 147.482641] [] sys_newstat+0x19/0x31 [ 147.482648] [] system_call+0x7e/0x83 [ 147.482652] [ 147.483066] VFS: brelse: Trying to free free buffer [ 147.483069] BUG: at fs/buffer.c:1164 __brelse() [ 147.483071] [ 147.483072] Call Trace: [ 147.483081] [] :btrfs:close_ctree+0xbb/0x191 [ 147.483086] [] dispose_list+0xad/0xc9 [ 147.483091] [] invalidate_inodes+0xc3/0xd5 [ 147.483099] [] :btrfs:btrfs_put_super+0x10/0x31 [ 147.483103] [] generic_shutdown_super+0x5b/0xd2 [ 147.483107] [] kill_block_super+0x26/0x3b [ 147.483111] [] deactivate_super+0x3d/0x55 [ 147.483116] [] sys_umount+0x1ca/0x1f1 [ 147.483121] [] sys_newstat+0x19/0x31 [ 147.483127] [] system_call+0x7e/0x83