From: Carsten Otte <cotte@de.ibm.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Yan Zheng <yanzheng@21cn.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [BUG?]Set XIP mount option on ext2 bypass check.
Date: Thu, 21 Jun 2007 13:17:10 +0200 [thread overview]
Message-ID: <467A5E36.9030904@de.ibm.com> (raw)
In-Reply-To: <3d0408630706201840o5b1c2454n75d1ebbd26d660d6@mail.gmail.com>
Yan Zheng wrote:
> I mount an ext2 fs , then remount it with xip option set.
> I get message below when do write operation in the fs.
Ouch. Like on mount, we should refuse -o xip on remount. The patch
below fixes this issue.
Signed-off-by: Carsten Otte <cotte@de.ibm.com>
---
Index: linux-2.6.22-rc4-mm/fs/ext2/super.c
===================================================================
--- linux-2.6.22-rc4-mm.orig/fs/ext2/super.c
+++ linux-2.6.22-rc4-mm/fs/ext2/super.c
@@ -1071,6 +1071,9 @@ static int ext2_remount (struct super_bl
sb->s_flags = (sb->s_flags & ~MS_POSIXACL) |
((sbi->s_mount_opt & EXT2_MOUNT_POSIX_ACL) ? MS_POSIXACL : 0);
+ ext2_xip_verify_sb(sb); /* see if bdev supports xip, unset
+ EXT2_MOUNT_XIP if not */
+
es = sbi->s_es;
if (((sbi->s_mount_opt & EXT2_MOUNT_XIP) !=
(old_mount_opt & EXT2_MOUNT_XIP)) &&
next prev parent reply other threads:[~2007-06-21 11:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-20 22:09 [BUG?]Set XIP mount option on ext2 bypass check Yan Zheng
2007-06-21 1:40 ` Yan Zheng
2007-06-21 11:17 ` Carsten Otte [this message]
2007-06-21 13:17 ` Carsten Otte
2007-06-21 23:22 ` Arnd Bergmann
2007-06-22 12:19 ` Satyam Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=467A5E36.9030904@de.ibm.com \
--to=cotte@de.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=carsteno@de.ibm.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yanzheng@21cn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).