From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Otte Subject: Re: [BUG?]Set XIP mount option on ext2 bypass check. Date: Thu, 21 Jun 2007 13:17:10 +0200 Message-ID: <467A5E36.9030904@de.ibm.com> References: <4679A58C.2080008@21cn.com> <3d0408630706201840o5b1c2454n75d1ebbd26d660d6@mail.gmail.com> Reply-To: carsteno@de.ibm.com Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Yan Zheng , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Andrew Morton Return-path: Received: from mtagate8.de.ibm.com ([195.212.29.157]:25465 "EHLO mtagate8.de.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753787AbXFULSA (ORCPT ); Thu, 21 Jun 2007 07:18:00 -0400 In-Reply-To: <3d0408630706201840o5b1c2454n75d1ebbd26d660d6@mail.gmail.com> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Yan Zheng wrote: > I mount an ext2 fs , then remount it with xip option set. > I get message below when do write operation in the fs. Ouch. Like on mount, we should refuse -o xip on remount. The patch below fixes this issue. Signed-off-by: Carsten Otte --- Index: linux-2.6.22-rc4-mm/fs/ext2/super.c =================================================================== --- linux-2.6.22-rc4-mm.orig/fs/ext2/super.c +++ linux-2.6.22-rc4-mm/fs/ext2/super.c @@ -1071,6 +1071,9 @@ static int ext2_remount (struct super_bl sb->s_flags = (sb->s_flags & ~MS_POSIXACL) | ((sbi->s_mount_opt & EXT2_MOUNT_POSIX_ACL) ? MS_POSIXACL : 0); + ext2_xip_verify_sb(sb); /* see if bdev supports xip, unset + EXT2_MOUNT_XIP if not */ + es = sbi->s_es; if (((sbi->s_mount_opt & EXT2_MOUNT_XIP) != (old_mount_opt & EXT2_MOUNT_XIP)) &&