From: Chris Snook <csnook@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Stephen Tweedie <sct@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, Chris Snook <csnook@redhat.com>
Subject: [PATCH 0/2] remove printk() from J_ASSERT macros
Date: Mon, 20 Aug 2007 10:19:58 -0400 [thread overview]
Message-ID: <46C9A30E.3050103@redhat.com> (raw)
The printk() in J_ASSERT clobbers registers, making it more difficult to
determine what caused the assertion failure. We can deduce the assertion itself
from the line number in the BUG() message, so let's just use that, and keep our
registers intact for better debugging. While the hood is up, also remove a
superfluous #define/#ifdef.
-- Chris
next reply other threads:[~2007-08-20 14:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-20 14:19 Chris Snook [this message]
2007-08-20 14:24 ` [PATCH 1/2] jbd: remove printk() from J_ASSERT macros Chris Snook
2007-08-20 14:26 ` [PATCH 2/2] jbd2: " Chris Snook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46C9A30E.3050103@redhat.com \
--to=csnook@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=sct@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).