From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Snook Subject: [PATCH 0/2] remove printk() from J_ASSERT macros Date: Mon, 20 Aug 2007 10:19:58 -0400 Message-ID: <46C9A30E.3050103@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org, Chris Snook To: Andrew Morton , Stephen Tweedie Return-path: Received: from mx1.redhat.com ([66.187.233.31]:58978 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755543AbXHTOUG (ORCPT ); Mon, 20 Aug 2007 10:20:06 -0400 Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org The printk() in J_ASSERT clobbers registers, making it more difficult to determine what caused the assertion failure. We can deduce the assertion itself from the line number in the BUG() message, so let's just use that, and keep our registers intact for better debugging. While the hood is up, also remove a superfluous #define/#ifdef. -- Chris