From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rik van Riel <riel@redhat.com>
Subject: Re: [RFC 13/26] SLUB: Add SlabReclaimable() to avoid repeated reclaim
 attempts
Date: Wed, 19 Sep 2007 11:08:28 -0400
Message-ID: <46F13B6C.7020501@redhat.com>
References: <20070901014107.719506437@sgi.com> <20070901014222.303468369@sgi.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Andy Whitcroft <apw@shadowen.org>, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
	Christoph Hellwig <hch@lst.de>, Mel Gorman <mel@skynet.ie>,
	David Chinner <dgc@sgi.com>
To: Christoph Lameter <clameter@sgi.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mx1.redhat.com ([66.187.233.31]:46078 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753549AbXISPIt (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Wed, 19 Sep 2007 11:08:49 -0400
In-Reply-To: <20070901014222.303468369@sgi.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

Christoph Lameter wrote:
> Add a flag SlabReclaimable() that is set on slabs with a method
> that allows defrag/reclaim. Clear the flag if a reclaim action is not
> successful in reducing the number of objects in a slab. The reclaim
> flag is set again if all objects have been allocated from it.
> 
> Signed-off-by: Christoph Lameter <clameter@sgi.com>
> ---
>  mm/slub.c |   42 ++++++++++++++++++++++++++++++++++++------
>  1 file changed, 36 insertions(+), 6 deletions(-)
> 
> Index: linux-2.6/mm/slub.c
> ===================================================================
> --- linux-2.6.orig/mm/slub.c	2007-08-28 20:10:37.000000000 -0700
> +++ linux-2.6/mm/slub.c	2007-08-28 20:10:47.000000000 -0700
> @@ -107,6 +107,8 @@
>  #define SLABDEBUG 0
>  #endif
>  
> +#define SLABRECLAIMABLE (1 << PG_dirty)
> +
>  static inline int SlabFrozen(struct page *page)
>  {
>  	return page->flags & FROZEN;
> @@ -137,6 +139,21 @@ static inline void ClearSlabDebug(struct
>  	page->flags &= ~SLABDEBUG;
>  }
>  
> +static inline int SlabReclaimable(struct page *page)
> +{
> +	return page->flags & SLABRECLAIMABLE;
> +}
> +
> +static inline void SetSlabReclaimable(struct page *page)
> +{
> +	page->flags |= SLABRECLAIMABLE;
> +}
> +
> +static inline void ClearSlabReclaimable(struct page *page)
> +{
> +	page->flags &= ~SLABRECLAIMABLE;
> +}

Why is it safe to not use the normal page flag bit operators
for these page flags operations?

-- 
Politics is the struggle between those who want to make their country
the best in the world, and those who believe it already is.  Each group
calls the other unpatriotic.