From mboxrd@z Thu Jan  1 00:00:00 1970
From: roel <12o3l@tiscali.nl>
Subject: Re: [PATCH 13/25] Unionfs: add un/likely conditionals on dir ops
Date: Wed, 26 Sep 2007 23:40:34 +0200
Message-ID: <46FAD1D2.8030306@tiscali.nl>
References: <11907762042481-git-send-email-ezk@cs.sunysb.edu> <11907762104036-git-send-email-ezk@cs.sunysb.edu>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, viro@ftp.linux.org.uk,
	hch@infradead.org
To: Erez Zadok <ezk@cs.sunysb.edu>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from smtp-out1.tiscali.nl ([195.241.79.176]:42607 "EHLO
	smtp-out1.tiscali.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753099AbXIZVkn (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Wed, 26 Sep 2007 17:40:43 -0400
In-Reply-To: <11907762104036-git-send-email-ezk@cs.sunysb.edu>
Sender: linux-fsdevel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

Erez Zadok wrote:

> @@ -194,7 +194,7 @@ int check_empty(struct dentry *dentry, struct unionfs_dir_state **namelist)
>  
>  	BUG_ON(!S_ISDIR(dentry->d_inode->i_mode));
>  
> -	if ((err = unionfs_partial_lookup(dentry)))
> +	if (unlikely((err = unionfs_partial_lookup(dentry))))
>  		goto out;
>  
>  	bstart = dbstart(dentry);

Is it bad to leave this assignment within the unlikely()?