From: Zach Brown <zach.brown@oracle.com>
To: Roland Dreier <rdreier@cisco.com>
Cc: David Howells <dhowells@redhat.com>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 01/31] Add an ERR_CAST() macro to complement ERR_PTR and co. [try #5]
Date: Thu, 25 Oct 2007 17:20:25 -0700 [thread overview]
Message-ID: <472132C9.20903@oracle.com> (raw)
In-Reply-To: <aday7dqzrwh.fsf@cisco.com>
Roland Dreier wrote:
> > > +static inline void *ERR_CAST(const void *ptr)
> > > +{
> > > + return (void *) ptr;
> > > +}
> >
> > Just to nit, surely you don't need the cast inside the function. The
> > casting happens at the call site between the argument and returned pointer.
>
> The way it's written you kinda do, since it takes a const void * and
> returns a plain void *.
Ah, right, I missed that.
- z
next prev parent reply other threads:[~2007-10-26 0:20 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-25 16:33 [PATCH 00/31] Remove iget() and read_inode() [try #5] David Howells
2007-10-25 16:33 ` [PATCH 01/31] Add an ERR_CAST() macro to complement ERR_PTR and co. " David Howells
2007-10-25 23:09 ` Zach Brown
2007-10-25 23:38 ` Roland Dreier
2007-10-26 0:20 ` Zach Brown [this message]
2007-10-25 23:46 ` Andrew Morton
2007-10-25 16:34 ` [PATCH 02/31] Convert ERR_PTR(PTR_ERR(p)) instances to ERR_CAST(p) " David Howells
2007-10-25 16:34 ` [PATCH 03/31] IGET: Introduce a function to register iget failure " David Howells
2007-10-25 16:34 ` [PATCH 04/31] IGET: Use iget_failed() in AFS " David Howells
2007-10-25 16:34 ` [PATCH 05/31] IGET: Use iget_failed() in GFS2 " David Howells
2007-10-25 16:34 ` [PATCH 06/31] IGET: Stop AFFS from using iget() and read_inode() " David Howells
2007-10-25 16:34 ` [PATCH 07/31] IGET: Stop autofs " David Howells
2007-10-25 16:34 ` [PATCH 08/31] IGET: Stop BEFS " David Howells
2007-10-25 16:34 ` [PATCH 09/31] IGET: Stop BFS " David Howells
2007-10-25 16:34 ` [PATCH 10/31] IGET: Stop CIFS " David Howells
2007-10-25 16:34 ` [PATCH 11/31] IGET: Stop EFS " David Howells
2007-10-25 16:34 ` [PATCH 12/31] IGET: Stop EXT2 " David Howells
2007-10-25 16:34 ` [PATCH 13/31] IGET: Stop EXT3 " David Howells
2007-10-25 16:35 ` [PATCH 14/31] IGET: Stop EXT4 " David Howells
2007-10-25 16:35 ` [PATCH 15/31] IGET: Stop FAT " David Howells
2007-10-25 16:35 ` [PATCH 16/31] IGET: Stop FreeVXFS " David Howells
2007-11-06 10:25 ` Andrew Morton
2007-11-06 11:09 ` David Howells
2007-11-06 11:13 ` David Howells
2007-10-25 16:35 ` [PATCH 17/31] IGET: Stop FUSE " David Howells
2007-10-25 16:35 ` [PATCH 18/31] IGET: Stop HFSPLUS " David Howells
2007-10-25 16:35 ` [PATCH 19/31] IGET: Stop ISOFS from using " David Howells
2007-10-25 16:35 ` [PATCH 20/31] IGET: Stop JFFS2 from using iget() and " David Howells
2007-10-25 16:35 ` [PATCH 21/31] IGET: Stop JFS " David Howells
2007-10-25 16:35 ` [PATCH 22/31] IGET: Stop the MINIX filesystem " David Howells
2007-10-25 16:35 ` [PATCH 23/31] IGET: Stop PROCFS " David Howells
2007-10-25 16:36 ` [PATCH 24/31] IGET: Stop QNX4 " David Howells
2007-10-25 16:36 ` [PATCH 25/31] IGET: Stop ROMFS " David Howells
2007-10-25 16:36 ` [PATCH 26/31] IGET: Stop the SYSV filesystem " David Howells
2007-10-25 16:36 ` [PATCH 27/31] IGET: Stop UFS " David Howells
2007-10-25 16:36 ` [PATCH 28/31] IGET: Stop OPENPROMFS " David Howells
2007-10-25 16:36 ` [PATCH 29/31] IGET: Stop HOSTFS " David Howells
2007-10-25 16:36 ` [PATCH 30/31] IGET: Stop HPPFS " David Howells
2007-10-25 16:36 ` [PATCH 31/31] IGET: Remove iget() and the read_inode() super op as being obsolete " David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=472132C9.20903@oracle.com \
--to=zach.brown@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).