linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mike Waychison <mikew@google.com>
To: Chris Mason <chris.mason@oracle.com>
Cc: Anton Altaparmakov <aia21@cam.ac.uk>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	adilger@clusterfs.com
Subject: Re: [patch 0/6][RFC] Cleanup FIBMAP
Date: Mon, 29 Oct 2007 12:16:23 -0700	[thread overview]
Message-ID: <47263187.5070106@google.com> (raw)
In-Reply-To: <20071029101001.4378a7cf@think.oraclecorp.com>

Chris Mason wrote:
> On Sat, 27 Oct 2007 18:57:06 +0100
> Anton Altaparmakov <aia21@cam.ac.uk> wrote:
> 
>> Hi,
>>
>> ->bmap is ugly and horrible!  If you have to do this at the very
>> least please cause ->bmap64 to be able to return error values in case
>> the file system failed to get the information or indeed such
>> information does not exist as is the case for compressed and
>> encrypted files for example and also for small files that are inside
>> the on-disk inode (NTFS resident files and reiserfs packed tails are
>> examples of this).
>>
>> And another of my pet peeves with ->bmap is that it uses 0 to mean  
>> "sparse" which causes a conflict on NTFS at least as block zero is  
>> part of the $Boot system file so it is a real, valid block...  NTFS  
>> uses -1 to denote sparse blocks internally.
> 
> Reiserfs and Btrfs also use 0 to mean packed.  It would be nice if there
> was a way to indicate your-data-is-here-but-isn't-alone.  But that's
> more of a feature for the FIEMAP stuff.
> 

I hadn't heard of FIEMAP, so I went back and read the thread from 
April/May.  It seems that this is a much better approach than 
introducing a FIBMAP64.

What ever happened with this proposal?

Mike Waychison

  parent reply	other threads:[~2007-10-29 19:17 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-26 23:37 [patch 0/6][RFC] Cleanup FIBMAP Mike Waychison
2007-10-26 23:37 ` [patch 1/6][RFC] Keep FIBMAP from looking at negative block nrs Mike Waychison
2007-10-26 23:37 ` [patch 2/6][RFC] Allow FIBMAP to return EFBIG on large filesystems Mike Waychison
2007-10-26 23:37 ` [patch 3/6][RFC] Move FIBMAP logic Mike Waychison
2007-10-26 23:37 ` [patch 4/6][RFC] Attempt to plug race with truncate Mike Waychison
2007-10-29 13:36   ` Chris Mason
2007-10-26 23:37 ` [patch 5/6][RFC] Introduce FIBMAP64 Mike Waychison
2007-10-29 13:45   ` Chris Mason
2007-10-26 23:37 ` [patch 6/6][RFC] Drop CAP_SYS_RAWIO requirement on FIBMAP Mike Waychison
2007-10-27 17:57 ` [patch 0/6][RFC] Cleanup FIBMAP Anton Altaparmakov
2007-10-27 21:45   ` Szabolcs Szakacsits
2007-10-29 14:10   ` Chris Mason
2007-10-29 16:30     ` Zach Brown
2007-10-29 19:18       ` Mike Waychison
2007-10-29 19:46         ` Chris Mason
2007-10-29 20:01           ` Zach Brown
2007-10-29 20:00         ` Zach Brown
2007-10-31 11:06           ` Ric Wheeler
2007-10-31 16:16             ` Zach Brown
2007-10-31 17:17               ` Ric Wheeler
2007-10-29 19:16     ` Mike Waychison [this message]
2007-10-29 19:47       ` Andreas Dilger
2007-10-28  0:43 ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47263187.5070106@google.com \
    --to=mikew@google.com \
    --cc=adilger@clusterfs.com \
    --cc=aia21@cam.ac.uk \
    --cc=chris.mason@oracle.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).