From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Waychison Subject: Re: [patch 0/6][RFC] Cleanup FIBMAP Date: Mon, 29 Oct 2007 12:16:23 -0700 Message-ID: <47263187.5070106@google.com> References: <20071026233732.568575496@crlf.corp.google.com> <20071029101001.4378a7cf@think.oraclecorp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Anton Altaparmakov , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, adilger@clusterfs.com To: Chris Mason Return-path: Received: from smtp-out.google.com ([216.239.33.17]:45895 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750875AbXJ2TRO (ORCPT ); Mon, 29 Oct 2007 15:17:14 -0400 In-Reply-To: <20071029101001.4378a7cf@think.oraclecorp.com> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Chris Mason wrote: > On Sat, 27 Oct 2007 18:57:06 +0100 > Anton Altaparmakov wrote: > >> Hi, >> >> ->bmap is ugly and horrible! If you have to do this at the very >> least please cause ->bmap64 to be able to return error values in case >> the file system failed to get the information or indeed such >> information does not exist as is the case for compressed and >> encrypted files for example and also for small files that are inside >> the on-disk inode (NTFS resident files and reiserfs packed tails are >> examples of this). >> >> And another of my pet peeves with ->bmap is that it uses 0 to mean >> "sparse" which causes a conflict on NTFS at least as block zero is >> part of the $Boot system file so it is a real, valid block... NTFS >> uses -1 to denote sparse blocks internally. > > Reiserfs and Btrfs also use 0 to mean packed. It would be nice if there > was a way to indicate your-data-is-here-but-isn't-alone. But that's > more of a feature for the FIEMAP stuff. > I hadn't heard of FIEMAP, so I went back and read the thread from April/May. It seems that this is a much better approach than introducing a FIBMAP64. What ever happened with this proposal? Mike Waychison