From: Qi Zheng <zhengqi.arch@bytedance.com>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: dvyukov@google.com, willy@infradead.org, akinobu.mita@gmail.com,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] mm: fix unexpected changes to {failslab|fail_page_alloc}.attr
Date: Mon, 7 Nov 2022 23:05:42 +0800 [thread overview]
Message-ID: <4736d199-7e70-6bc3-30e6-0f644c81a10c@bytedance.com> (raw)
In-Reply-To: <Y2j9Q/yMmqgPPUoO@nvidia.com>
On 2022/11/7 20:42, Jason Gunthorpe wrote:
> On Mon, Nov 07, 2022 at 11:31:09AM +0800, Qi Zheng wrote:
>
>> @@ -31,9 +33,9 @@ bool __should_failslab(struct kmem_cache *s, gfp_t gfpflags)
>> return false;
>>
>> if (gfpflags & __GFP_NOWARN)
>> - failslab.attr.no_warn = true;
>> + flags |= FAULT_NOWARN;
>
> You should add a comment here about why this is required, to avoid
> deadlocking printk
I think this comment should be placed where __GFP_NOWARN is specified
instead of here. What do you think? :)
Thanks,
Qi
>
> Jason
--
Thanks,
Qi
next prev parent reply other threads:[~2022-11-07 15:05 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 19:09 xarray, fault injection and syzkaller Jason Gunthorpe
2022-11-03 20:00 ` Matthew Wilcox
2022-11-03 20:07 ` Jason Gunthorpe
2022-11-04 0:11 ` Dmitry Vyukov
2022-11-04 0:21 ` Jason Gunthorpe
2022-11-04 17:47 ` Dmitry Vyukov
2022-11-04 18:03 ` Jason Gunthorpe
2022-11-04 18:21 ` Dmitry Vyukov
2022-11-04 18:30 ` Jason Gunthorpe
2022-11-04 18:38 ` Dmitry Vyukov
2022-11-04 18:45 ` Jason Gunthorpe
2022-11-04 22:43 ` Qi Zheng
2022-11-05 12:16 ` Qi Zheng
2022-11-06 17:36 ` Dmitry Vyukov
2022-11-07 2:13 ` Qi Zheng
2022-11-07 3:31 ` [PATCH] mm: fix unexpected changes to {failslab|fail_page_alloc}.attr Qi Zheng
2022-11-07 12:42 ` Jason Gunthorpe
2022-11-07 15:05 ` Qi Zheng [this message]
2022-11-07 16:26 ` Jason Gunthorpe
2022-11-08 2:47 ` Qi Zheng
2022-11-08 3:52 ` [PATCH v2] " Qi Zheng
2022-11-08 8:44 ` Wei Yongjun
2022-11-08 8:58 ` Qi Zheng
2022-11-08 9:32 ` Wei Yongjun
2022-11-08 9:45 ` Qi Zheng
2022-11-08 12:04 ` Jason Gunthorpe
2022-11-09 3:57 ` Wei Yongjun
2022-11-08 17:36 ` Akinobu Mita
2022-11-14 3:59 ` Qi Zheng
2022-11-04 18:42 ` xarray, fault injection and syzkaller Dmitry Vyukov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4736d199-7e70-6bc3-30e6-0f644c81a10c@bytedance.com \
--to=zhengqi.arch@bytedance.com \
--cc=akinobu.mita@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dvyukov@google.com \
--cc=jgg@nvidia.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=stable@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).