From: Phillip Lougher <phillip@lougher.demon.co.uk>
To: Christoph Hellwig <hch@infradead.org>
Cc: Dave Jones <davej@redhat.com>, maximilian attems <max@stro.at>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [ANN] Squashfs 3.3 released
Date: Wed, 21 Nov 2007 15:00:23 +0000 [thread overview]
Message-ID: <47444807.9050803@lougher.demon.co.uk> (raw)
In-Reply-To: <20071121144835.GA7556@infradead.org>
Christoph Hellwig wrote:
> On Wed, Nov 21, 2007 at 02:02:43PM +0000, Phillip Lougher wrote:
>> Unfortunately the move to fixed little endian filesystem will involve
>> another filesystem layout change. The current filesystem layout still
>> uses packed bitfield structures, and it is impossible to swap these
>> using the standard kernel swap macros. Removal of my routines that can
>> properly swap packed bitfield structures is another change demanded by
>> the Linux kernel mailing list.
>
> The normal way to do it is to use shift and mask after doing the endian
> conversion. But the problem with bitfields is that they can have different
> kinds of layouts depending on the compiler or abi which is another reason
> to avoid them in ondisk/wire formats.
>
Yes, the bitfields are packed differently on little and big endian
architectures which mean they appear in different places in the
structure. I want to move away from that mess when I move to little
endian only.
Phillip
next prev parent reply other threads:[~2007-11-21 14:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-05 11:13 [ANN] Squashfs 3.3 released Phillip Lougher
2007-11-05 11:56 ` maximilian attems
2007-11-07 16:32 ` Phillip Lougher
2007-11-20 23:50 ` Dave Jones
2007-11-21 14:02 ` Phillip Lougher
2007-11-21 14:48 ` Christoph Hellwig
2007-11-21 15:00 ` Phillip Lougher [this message]
2007-11-05 23:19 ` Michael Tokarev
2007-11-07 16:06 ` Phillip Lougher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47444807.9050803@lougher.demon.co.uk \
--to=phillip@lougher.demon.co.uk \
--cc=davej@redhat.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=max@stro.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).