From mboxrd@z Thu Jan  1 00:00:00 1970
From: Zach Brown <zach.brown@oracle.com>
Subject: Re: [PATCH]loop cleanup in fs/namespace.c - repost
Date: Wed, 21 Nov 2007 11:06:33 -0800
Message-ID: <474481B9.9000603@oracle.com>
References: <47447184.6040805@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=KOI8-R
Content-Transfer-Encoding: 7bit
Cc: linux-fsdevel@vger.kernel.org,
	Linux-kernel <linux-kernel@vger.kernel.org>
To: Dmitri Vorobiev <dmitri.vorobiev@gmail.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from tetsuo.zabbo.net ([207.173.201.20]:44159 "EHLO tetsuo.zabbo.net"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753582AbXKUTGs (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Wed, 21 Nov 2007 14:06:48 -0500
In-Reply-To: <47447184.6040805@gmail.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org


> The patch given below replaces the goto-loop by a while-based one.

That certainly looks fine.  I would also replace the 'return' with
'break', but I guess that's more of a question of personal preference.

> Besides, it removes the export for the same routine, because there are
> no users for it outside of the core VFS code.

This doesn't look fine.  Did you test this?

mntput_no_expire() is called from mntput() which is an inline function
in mount.h.  So lots of callers of mntput() in modules will end up
trying to call mntput_no_expire() from modules.

$ nm fs/fuse/fuse.ko | grep mntput_no_expire
                 U mntput_no_expire

- z