From: Zach Brown <zach.brown@oracle.com>
To: Dmitri Vorobiev <dmitri.vorobiev@gmail.com>
Cc: linux-fsdevel@vger.kernel.org,
Linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH]loop cleanup in fs/namespace.c - repost
Date: Wed, 21 Nov 2007 12:46:42 -0800 [thread overview]
Message-ID: <47449932.3090801@oracle.com> (raw)
In-Reply-To: <47448D0A.1040405@gmail.com>
>> This doesn't look fine. Did you test this?
>
> Oops, my fault. Of course, I tested the patch, but kernel modules are
> disabled in my test setup, so I missed the error.
:)
> Enclosed to this message is a new patch, which replaces the goto-loop by
> the while-based one, but leaves the EXPORT_SYMBOL macro intact.
It certainly looks OK to me now, for whatever that's worth.
You probably want to wait 'till the next merge window to get it in,
though. It's just a cleanup and so shouldn't go in this late in the -rc
line.
Maybe Andrew will be willing to queue it until that time in -mm.
- z
next prev parent reply other threads:[~2007-11-21 20:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-21 17:57 [PATCH]loop cleanup in fs/namespace.c - repost Dmitri Vorobiev
2007-11-21 19:06 ` Zach Brown
2007-11-21 19:54 ` Dmitri Vorobiev
2007-11-21 20:46 ` Zach Brown [this message]
2007-11-21 22:49 ` [PATCH] [2.6.24-rc3-mm1] loop " Dmitri Vorobiev
2007-11-21 23:24 ` Andrew Morton
2007-11-21 23:47 ` Dmitri Vorobiev
2007-11-26 10:30 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47449932.3090801@oracle.com \
--to=zach.brown@oracle.com \
--cc=dmitri.vorobiev@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).