From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zach Brown Subject: Re: [PATCH]loop cleanup in fs/namespace.c - repost Date: Wed, 21 Nov 2007 12:46:42 -0800 Message-ID: <47449932.3090801@oracle.com> References: <47447184.6040805@gmail.com> <474481B9.9000603@oracle.com> <47448D0A.1040405@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org, Linux-kernel To: Dmitri Vorobiev Return-path: Received: from tetsuo.zabbo.net ([207.173.201.20]:38390 "EHLO tetsuo.zabbo.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750712AbXKUUq4 (ORCPT ); Wed, 21 Nov 2007 15:46:56 -0500 In-Reply-To: <47448D0A.1040405@gmail.com> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org >> This doesn't look fine. Did you test this? > > Oops, my fault. Of course, I tested the patch, but kernel modules are > disabled in my test setup, so I missed the error. :) > Enclosed to this message is a new patch, which replaces the goto-loop by > the while-based one, but leaves the EXPORT_SYMBOL macro intact. It certainly looks OK to me now, for whatever that's worth. You probably want to wait 'till the next merge window to get it in, though. It's just a cleanup and so shouldn't go in this late in the -rc line. Maybe Andrew will be willing to queue it until that time in -mm. - z