Zach Brown пишет: >>> This doesn't look fine. Did you test this? >> Oops, my fault. Of course, I tested the patch, but kernel modules are >> disabled in my test setup, so I missed the error. > > :) > >> Enclosed to this message is a new patch, which replaces the goto-loop by >> the while-based one, but leaves the EXPORT_SYMBOL macro intact. > > It certainly looks OK to me now, for whatever that's worth. Zach, thank you for the code review and suggestions. > > You probably want to wait 'till the next merge window to get it in, > though. It's just a cleanup and so shouldn't go in this late in the -rc > line. > > Maybe Andrew will be willing to queue it until that time in -mm. I am enclosing the patch against current -mm tree and adding Andrew to the Cc: list. Thanks, Dmitri > > - z >