From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Otte Subject: Re: [patch] ext2: xip check fix Date: Thu, 06 Dec 2007 09:43:27 +0100 Message-ID: <4757B62F.2040608@de.ibm.com> References: <20071204042628.GA26636@wotan.suse.de> <200712041054.51599.borntraeger@de.ibm.com> <20071204101009.GB9618@wotan.suse.de> <20071204112100.GA20420@wotan.suse.de> <20071204112327.GB20420@wotan.suse.de> <4756C714.2040809@de.ibm.com> <20071205233345.GB5617@wotan.suse.de> Reply-To: carsteno@de.ibm.com Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: carsteno@de.ibm.com, Christian Borntraeger , Linux Kernel Mailing List , linux-fsdevel@vger.kernel.org, "Eric W. Biederman" , Andrew Morton , rob@landley.net, Jens Axboe To: Nick Piggin Return-path: Received: from mout2.freenet.de ([195.4.92.92]:39859 "EHLO mout2.freenet.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751593AbXLFIng (ORCPT ); Thu, 6 Dec 2007 03:43:36 -0500 In-Reply-To: <20071205233345.GB5617@wotan.suse.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Nick Piggin wrote: >> Xip does only work, if both do match PAGE_SIZE because it >> does'nt support multiple calls to direct_access in the get_xip_page >> address space operation. Thus we check both here, actually this was >> changed from how it looks after your patch as a bugfix where our >> tester tried a 4k filesystem on a 2k blockdev. >> Did I miss something? > > However, the bdev block size may be changed with sb_set_blocksize. It > doesn't actually have to match the hardware sector size -- if this > does matter for XIP, then I think you need some other check here. Hmmmmhh. For a bdev with PAGE_SIZE hardsect size, there is no other valid value then PAGE_SIZE that one could set it to. Or can it indeed be changed to a value greater then PAGE_SIZE or smaller then hardsect size?