From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Otte Subject: Re: [patch] ext2: xip check fix Date: Fri, 07 Dec 2007 09:59:42 +0100 Message-ID: <47590B7E.5040608@de.ibm.com> References: <20071204042628.GA26636@wotan.suse.de> <20071206101848.GC25202@wotan.suse.de> <4757CDD4.5090606@de.ibm.com> <200712061211.49443.rob@landley.net> <6934efce0712061922j682cee55pc1d5d079465f4849@mail.gmail.com> Reply-To: carsteno@de.ibm.com Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Rob Landley , carsteno@de.ibm.com, Nick Piggin , Christian Borntraeger , Linux Kernel Mailing List , linux-fsdevel@vger.kernel.org, "Eric W. Biederman" , Andrew Morton , Jens Axboe To: Jared Hulbert Return-path: In-Reply-To: <6934efce0712061922j682cee55pc1d5d079465f4849@mail.gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Jared Hulbert wrote: > I think so. The filemap_xip.c functionality doesn't work for Flash > memory yet. Flash memory doesn't have struct pages to back it up with > which this stuff depends on. Struct page is not the major issue. The primary problem is writing to the media (and I am not a flash expert at all, just relaying here): For some period of time, the flash memory is not usable and thus we need to make sure we can nuke the page table entries that we have in userland page tables. For that, we need a callback from the device so that it can ask to get its references back. Oh, and a put_xip_page counterpart to get_xip_page, so that the driver knows when it's safe to erase. cheers, Carsten