From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dmitri Vorobiev <dmitri.vorobiev@gmail.com>
Subject: Re: [PATCH v2 8/9] bfs: remove multiple assignments
Date: Wed, 30 Jan 2008 16:36:54 +0300
Message-ID: <47A07D76.6010605@gmail.com>
References: <1201296027-6900-1-git-send-email-dmitri.vorobiev@gmail.com> <1201296027-6900-9-git-send-email-dmitri.vorobiev@gmail.com> <Pine.LNX.4.61.0801261833270.1966@ginsburg.homenet> <479BC6E5.5000409@gmail.com> <479D7DEB.7070806@austin.ibm.com> <20080130130656.GI27894@ZenIV.linux.org.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: Joel Schopp <jschopp@austin.ibm.com>,
	Dmitri Vorobiev <dmitri.vorobiev@gmail.com>,
	Tigran Aivazian <tigran@aivazian.fsnet.co.uk>,
	trivial@kernel.org, linux-fsdevel@vger.kernel.org,
	apw@shadowen.org, rdunlap@xenotime.net,
	Linux-kernel <linux-kernel@vger.kernel.org>
To: Al Viro <viro@ZenIV.linux.org.uk>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from fg-out-1718.google.com ([72.14.220.154]:31455 "EHLO
	fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750736AbYA3NhD (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Wed, 30 Jan 2008 08:37:03 -0500
Received: by fg-out-1718.google.com with SMTP id e21so237099fga.17
        for <linux-fsdevel@vger.kernel.org>; Wed, 30 Jan 2008 05:37:02 -0800 (PST)
In-Reply-To: <20080130130656.GI27894@ZenIV.linux.org.uk>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

Al Viro wrote:
> On Mon, Jan 28, 2008 at 01:02:03AM -0600, Joel Schopp wrote:
>>>>> -    inode->i_mtime = inode->i_atime = inode->i_ctime = CURRENT_TIME_SEC;
>>>>> +    inode->i_mtime = CURRENT_TIME_SEC;
>>>>> +    inode->i_atime = CURRENT_TIME_SEC;
>>>>> +    inode->i_ctime = CURRENT_TIME_SEC;
>>>> multiple assignments like "x = y = z = value;" can potentially
>>>> (depending on the compiler and arch) be faster than "x = value; y =
>>>> value; z=value;"
>>>>
>>>> I am surprized that this script complains about them as it is a
>>>> perfectly valid thing to do in C.
>>> I think it seems wise to ask the maintainers of checkpatch.pl to
>>> comment on that. I'm Cc:ing them now.
>>>
>> There are plenty of things that are valid to do in C that don't make for 
>> maintainable code.  These scripts are designed to make your code easier for 
>> real people to review and maintain.
> 
> Except that in this case the new variant is not equivalent to the old one...

Yes, you're right. In fact, I felt like sending yet another version
of these patches, but this gets preempted all the time by "the other things".

Dmitri