From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Otte Subject: Re: [patch 4/6] xip: support non-struct page backed memory Date: Mon, 03 Mar 2008 09:18:21 +0100 Message-ID: <47CBB44D.7040203@de.ibm.com> References: <20080118045649.334391000@suse.de> <20080118045755.735923000@suse.de> <6934efce0803010014p2cc9a5edu5fee2029c0104a07@mail.gmail.com> Reply-To: carsteno@de.ibm.com Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: npiggin@suse.de, Linus Torvalds , Andrew Morton , mschwid2@linux.vnet.ibm.com, heicars2@linux.vnet.ibm.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org To: Jared Hulbert Return-path: Received: from mout3.freenet.de ([195.4.92.93]:55968 "EHLO mout3.freenet.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752803AbYCCISi (ORCPT ); Mon, 3 Mar 2008 03:18:38 -0500 In-Reply-To: <6934efce0803010014p2cc9a5edu5fee2029c0104a07@mail.gmail.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Jared Hulbert wrote: > The problem is that virt_to_phys() gives bogus answer for a > mtd->point()'ed address. It's a ioremap()'ed address which doesn't > work with the ARM virt_to_phys(). I can get a physical address from > mtd->point() with a patch I dropped a little while back. Is there a chance virt_to_phys() can be fixed on arm? It looks like a simple page table walk to me. If not, I would prefer to have get_xip_address return a physical address over having to split the code path here. S390 has a 1:1 mapping for xip mappings, thus it would'nt be a big change for us.