From: Carsten Otte <cotte@de.ibm.com>
To: Nick Piggin <npiggin@suse.de>
Cc: Jared Hulbert <jaredeh@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
mschwid2@linux.vnet.ibm.com, heicars2@linux.vnet.ibm.com,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org
Subject: Re: [patch 4/6] xip: support non-struct page backed memory
Date: Mon, 03 Mar 2008 09:30:29 +0100 [thread overview]
Message-ID: <47CBB725.7040108@de.ibm.com> (raw)
In-Reply-To: <20080303052959.GB32555@wotan.suse.de>
Nick Piggin wrote:
> What about
> int get_xip_mem(mapping, pgoff, create, void **kaddr, unsigned long *pfn)
>
> get_xip_mem(mapping, pgoff, create, &addr, &pfn);
> if (pagefault)
> vm_insert_mixed(vma, vaddr, pfn);
> else if (read/write) {
> memcpy(kaddr, blah, sizeof);
>
> My simple brd driver can easily do
> *kaddr = page_address(page);
> *pfn = page_to_pfn(page);
>
> This should work for you too?
Looks good to me. Otoh, if there is an easy way to fix virt_to_phys()
I would like that better.
next prev parent reply other threads:[~2008-03-03 8:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080118045649.334391000@suse.de>
2008-01-18 4:56 ` [patch 4/6] xip: support non-struct page backed memory npiggin
2008-03-01 8:14 ` Jared Hulbert
2008-03-03 5:29 ` Nick Piggin
2008-03-03 8:30 ` Carsten Otte [this message]
2008-03-03 15:59 ` Jared Hulbert
2008-03-03 8:18 ` Carsten Otte
2008-03-03 15:44 ` Jared Hulbert
2008-03-03 18:40 ` Linus Torvalds
2008-03-03 19:38 ` Jared Hulbert
2008-03-03 20:04 ` Linus Torvalds
2008-03-03 20:32 ` Nick Piggin
2008-03-03 22:21 ` Linus Torvalds
2008-03-03 23:25 ` Jared Hulbert
2008-03-04 9:06 ` Carsten Otte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47CBB725.7040108@de.ibm.com \
--to=cotte@de.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=carsteno@de.ibm.com \
--cc=heicars2@linux.vnet.ibm.com \
--cc=jaredeh@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mschwid2@linux.vnet.ibm.com \
--cc=npiggin@suse.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).