From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zach Brown Subject: Re: correct use of vmtruncate()? Date: Wed, 30 Apr 2008 08:55:45 -0700 Message-ID: <48189681.5080504@oracle.com> References: <20080429100601.GO108924158@sgi.com> <481756A3.20601@oracle.com> <20080430072457.GB7791@skywalker> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: David Chinner , linux-fsdevel , linux-mm , xfs-oss To: "Aneesh Kumar K.V" Return-path: Received: from tetsuo.zabbo.net ([207.173.201.20]:60790 "EHLO tetsuo.zabbo.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755134AbYD3Pzq (ORCPT ); Wed, 30 Apr 2008 11:55:46 -0400 In-Reply-To: <20080430072457.GB7791@skywalker> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: >> This paragraph in particular reminds me of an outstanding bug with >> O_DIRECT and ext*. It isn't truncating partial allocations when a dio >> fails with ENOSPC. This was noticed by a user who saw that fsck found >> bocks outside i_size in the file that saw ENOSPC if they tried to >> unmount and check the volume after the failed write. > > This patch should be the fix I guess > http://lkml.org/lkml/2006/12/18/103 That's the thread related to the bug, yes, but that isn't the right fix as David's later messages in the thread indicate. - z