linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Igor Mammedov <niallain@gmail.com>
To: Steve French <smfrench@gmail.com>
Cc: "Q (Igor Mammedov)" <qwerty0987654321@mail.ru>,
	Jeremy Allison <jra@samba.org>, Jeff Layton <jlayton@redhat.com>,
	linux-cifs-client@lists.samba.org,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: dfs path construction fix - send dfs paths on all path based operations on share in dfs
Date: Wed, 14 May 2008 15:50:25 +0400	[thread overview]
Message-ID: <482AD201.5010200@gmail.com> (raw)
In-Reply-To: <524f69650805131545id9be81et97549c74ecd0e7c8@mail.gmail.com>

Steve French wrote:
> Samba was not handling paths without the \\server\share prefix (which
> our current code sends on QueryPathInfo) when "SHARE_IN_DFS" on
> operations such as rmdir and delete.
> 
> This patch fixes that:


Attempted to test patch and

-
 at the first attempt I've got oops caused by a missing CIFSGetDFSRefer patch,
 after digging it up and applying it, oops is disappeared. But it doesn't
 help much because your patch broke traversal over a dfs link,  at the moment
 dfs lookup relies on the second lookup attempt with a short path name (without
 tree name).
 BTW, you said that you almost made patch for a fake dfs inode,  it could fix
 things up.

+
 mkdir and rmdir on a dfs enabled share work (at least with samba), can't check 
 it on MS however.

PS:
 commiting CIFSGetDFSRefer patch will help to avoid oops-es and more people
 would be able to test the DFS related patches.

-- 

Best regards,

-------------------------
Igor Mammedov,
niallain "at" gmail.com





  reply	other threads:[~2008-05-14 11:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-13 22:45 dfs path construction fix - send dfs paths on all path based operations on share in dfs Steve French
2008-05-14 11:50 ` Igor Mammedov [this message]
     [not found]   ` <524f69650805141150u3975b19al9b33f76378b28be3@mail.gmail.com>
     [not found]     ` <524f69650805141853t2ca20b25hd8fa79d698445a62@mail.gmail.com>
2008-05-15  6:22       ` Steve French
2008-05-16 10:03 ` Igor Mammedov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=482AD201.5010200@gmail.com \
    --to=niallain@gmail.com \
    --cc=jlayton@redhat.com \
    --cc=jra@samba.org \
    --cc=linux-cifs-client@lists.samba.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=qwerty0987654321@mail.ru \
    --cc=smfrench@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).