From mboxrd@z Thu Jan 1 00:00:00 1970 From: Igor Mammedov Subject: Re: dfs path construction fix - send dfs paths on all path based operations on share in dfs Date: Wed, 14 May 2008 15:50:25 +0400 Message-ID: <482AD201.5010200@gmail.com> References: <524f69650805131545id9be81et97549c74ecd0e7c8@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: "Q (Igor Mammedov)" , Jeremy Allison , Jeff Layton , linux-cifs-client@lists.samba.org, linux-fsdevel To: Steve French Return-path: Received: from fk-out-0910.google.com ([209.85.128.191]:8847 "EHLO fk-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753183AbYENLua (ORCPT ); Wed, 14 May 2008 07:50:30 -0400 Received: by fk-out-0910.google.com with SMTP id 18so2704068fkq.5 for ; Wed, 14 May 2008 04:50:28 -0700 (PDT) In-Reply-To: <524f69650805131545id9be81et97549c74ecd0e7c8@mail.gmail.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Steve French wrote: > Samba was not handling paths without the \\server\share prefix (which > our current code sends on QueryPathInfo) when "SHARE_IN_DFS" on > operations such as rmdir and delete. > > This patch fixes that: Attempted to test patch and - at the first attempt I've got oops caused by a missing CIFSGetDFSRefer patch, after digging it up and applying it, oops is disappeared. But it doesn't help much because your patch broke traversal over a dfs link, at the moment dfs lookup relies on the second lookup attempt with a short path name (without tree name). BTW, you said that you almost made patch for a fake dfs inode, it could fix things up. + mkdir and rmdir on a dfs enabled share work (at least with samba), can't check it on MS however. PS: commiting CIFSGetDFSRefer patch will help to avoid oops-es and more people would be able to test the DFS related patches. -- Best regards, ------------------------- Igor Mammedov, niallain "at" gmail.com