From: Eric Sandeen <sandeen@sandeen.net>
To: Chris Mason <chris.mason@oracle.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Mark Fasheh <mfasheh@suse.com>,
linux-fsdevel@vger.kernel.org, Andreas Dilger <adilger@shaw.ca>,
Kalpak Shah <Kalpak.Shah@sun.com>,
Eric Sandeen <sandeen@redhat.com>,
Josef Bacik <jbacik@redhat.com>
Subject: Re: [RFC][PATCH 0/5] Fiemap, an extent mapping ioctl
Date: Tue, 27 May 2008 11:21:21 -0500 [thread overview]
Message-ID: <483C3501.60705@sandeen.net> (raw)
In-Reply-To: <200805270948.51898.chris.mason@oracle.com>
Chris Mason wrote:
> On Sunday 25 May 2008, Christoph Hellwig wrote:
>
> Thanks for doing this Mark ;)
>
>> On Sat, May 24, 2008 at 05:01:48PM -0700, Mark Fasheh wrote:
>>> * FIEMAP_FLAG_HSM_READ
>>> If the extent is offline, retrieve it before mapping and do not flag
>>> it as FIEMAP_EXTENT_SECONDARY. This flag has no effect if the file
>>> system does not support HSM.
>> Given that there's no HSM support in mainline this should not be added.
>> It'll be useful once we add proper HSM support, though :)
>>
>
> The HSM flag doesn't hurt, and it allows the people actually shipping hsm
> patches to use fiemap without extending the api themselves. Reserving the
> flag isn't a bad idea.
Here I agree. HSM is a generic enough concept, and I think this
interface's API w.r.t. HSM is well-enough defined that there's no reason
not to go ahead & put it in now, IMHO.
-Eric
next prev parent reply other threads:[~2008-05-27 16:21 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-25 0:01 [RFC][PATCH 0/5] Fiemap, an extent mapping ioctl Mark Fasheh
2008-05-25 19:42 ` Christoph Hellwig
2008-05-25 20:59 ` Brad Boyer
2008-05-26 10:59 ` Andreas Dilger
2008-05-26 18:04 ` Brad Boyer
2008-05-27 16:45 ` Christoph Hellwig
2008-05-27 21:10 ` Mark Fasheh
2008-05-27 13:48 ` Chris Mason
2008-05-27 16:21 ` Eric Sandeen [this message]
2008-05-27 16:47 ` Christoph Hellwig
2008-05-27 20:34 ` Joel Becker
2008-05-27 16:52 ` jim owens
2008-05-27 17:19 ` Chris Mason
2008-05-28 16:09 ` Andreas Dilger
2008-05-28 16:33 ` Chris Mason
2008-05-29 22:01 ` Andreas Dilger
2008-05-30 13:37 ` Chris Mason
2008-05-29 13:01 ` Christoph Hellwig
2008-05-29 20:17 ` Andreas Dilger
2008-05-27 18:56 ` Mark Fasheh
2008-05-27 20:31 ` Joel Becker
2008-05-27 20:49 ` Mark Fasheh
2008-05-28 5:14 ` Christoph Hellwig
2008-05-28 16:02 ` Andreas Dilger
2008-05-28 17:04 ` Joel Becker
2008-05-29 0:51 ` Dave Chinner
2008-05-29 13:02 ` Christoph Hellwig
2008-05-29 15:33 ` jim owens
2008-05-29 15:53 ` Jamie Lokier
2008-05-29 18:56 ` Joel Becker
2008-05-29 21:41 ` Andreas Dilger
2008-05-29 21:47 ` Joel Becker
2008-05-29 23:20 ` Andreas Dilger
2008-05-29 1:17 ` Andreas Dilger
2008-05-29 5:55 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=483C3501.60705@sandeen.net \
--to=sandeen@sandeen.net \
--cc=Kalpak.Shah@sun.com \
--cc=adilger@shaw.ca \
--cc=chris.mason@oracle.com \
--cc=hch@infradead.org \
--cc=jbacik@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mfasheh@suse.com \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).