Re: [PATCH]ext4: Fix ext4_mb_init_cache return error

Mingming Cao
2008-06-02T02:27:08Z

On Mon, 2008-06-02 at 09:16 +0800, Shen Feng wrote:
>
> Mingming Cao Wrote:
> > ext4: Fix ext4_mb_init_cache return error
> >
> > From: Mingming Cao <cmm@us.ibm.com>
> >
> > ext4_mb_init_cache() incorrectly always return EIO on success. This
> > causes the caller of ext4_mb_init_cache() fail when it checks
> > the return value.
> >
> > Signed-off-by: Mingming Cao <cmm@us.ibm.com>
> > ---
> > fs/ext4/mballoc.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Index: linux-2.6.26-rc4/fs/ext4/mballoc.c
> > ===================================================================
> > --- linux-2.6.26-rc4.orig/fs/ext4/mballoc.c 2008-06-01 12:55:19.000000000 -0700
> > +++ linux-2.6.26-rc4/fs/ext4/mballoc.c 2008-06-01 12:55:23.000000000 -0700
> > @@ -798,7 +798,7 @@ static int ext4_mb_init_cache(struct pag
> > for (i = 0; i < groups_per_page && bh[i]; i++)
> > wait_on_buffer(bh[i]);
> >
> > - err = -EIO;
> > + err = 0;
> > for (i = 0; i < groups_per_page && bh[i]; i++)
> > if (!buffer_uptodate(bh[i]))
> > goto out;
> >
> >
>
> I think the fix should be
>
> err = -EIO;
> for (i = 0; i < groups_per_page && bh[i]; i++)
> if (!buffer_uptodate(bh[i]))
> goto out;
> + err = 0;
>
> Is that right?
>

you are right, thanks for point this out.

Mingming
> Shen Feng
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html