From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Steve French (smfltc)" Subject: flush and EIO errors when writepages fails Date: Fri, 20 Jun 2008 11:19:19 -0500 Message-ID: <485BD887.8090608@us.ibm.com> References: <20080620073150.2bc9988e@tupile.poochiereds.net> <20080620091542.09edb43f@tupile.poochiereds.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Shirish S Pargaonkar , shaggy@linux.vnet.ibm.com, linux-fsdevel@vger.kernel.org To: Jeff Layton Return-path: Received: from e1.ny.us.ibm.com ([32.97.182.141]:58367 "EHLO e1.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751229AbYFTQSV (ORCPT ); Fri, 20 Jun 2008 12:18:21 -0400 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e1.ny.us.ibm.com (8.13.8/8.13.8) with ESMTP id m5KGIKlm029776 for ; Fri, 20 Jun 2008 12:18:20 -0400 Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v9.0) with ESMTP id m5KGIK6S231876 for ; Fri, 20 Jun 2008 12:18:20 -0400 Received: from d01av04.pok.ibm.com (loopback [127.0.0.1]) by d01av04.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m5KGIJa2008367 for ; Fri, 20 Jun 2008 12:18:19 -0400 In-Reply-To: <20080620091542.09edb43f@tupile.poochiereds.net> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: If flush fails to write all dirty pages (due to an I/O error on the server, server disk or networking stack) today the error (EIO) is marked in the inode, and returned on close. I think cifs_flush (which is called before close by the vfs) should also (perhaps after sleep a second or so then) retry at least once on the filemap_fdatawrite before giving up. (perhaps retry more if mounted hard) Thoughts?