From: Kentaro Makita <k-makita@np.css.fujitsu.com>
To: linux-kernel@vger.kernel.org
Cc: linux-fsdevel@vger.kernel.org, akpm@linux-foundation.org,
viro@ZenIV.linux.org.uk, harvey.harrison@gmail.com
Subject: [RESEND][PATCH -mm 1/2] vfs: fix coding style at dcache.c.
Date: Tue, 24 Jun 2008 10:45:14 +0900 [thread overview]
Message-ID: <486051AA.8000507@np.css.fujitsu.com> (raw)
o fix coding style at dcache.c. No behavior changed.
Signed-off-by: Kentaro Makita <k-makita@np.css.fujitsu.com>
---
fs/dcache.c | 21 ++++++++++-----------
1 files changed, 10 insertions(+), 11 deletions(-)
Index: b/fs/dcache.c
===================================================================
--- a/fs/dcache.c 2008-06-05 11:44:26.000000000 +0900
+++ b/fs/dcache.c 2008-06-05 11:48:57.000000000 +0900
@@ -453,15 +453,15 @@ static void __shrink_dcache_sb(struct su
int cnt = 0;
BUG_ON(!sb);
- BUG_ON((flags & DCACHE_REFERENCED) && count == NULL);
+ BUG_ON((flags & DCACHE_REFERENCED) && !count);
spin_lock(&dcache_lock);
- if (count != NULL)
+ if (count)
/* called from prune_dcache() and shrink_dcache_parent() */
cnt = *count;
restart:
- if (count == NULL)
+ if (!count) {
list_splice_init(&sb->s_dentry_lru, &tmp);
- else {
+ } else {
while (!list_empty(&sb->s_dentry_lru)) {
dentry = list_entry(sb->s_dentry_lru.prev,
struct dentry, d_lru);
@@ -473,16 +473,15 @@ restart:
* the dentry has this flag set, don't free it. Clear
* the flag and put it back on the LRU.
*/
- if ((flags & DCACHE_REFERENCED)
- && (dentry->d_flags & DCACHE_REFERENCED)) {
+ if ((flags & DCACHE_REFERENCED) &&
+ (dentry->d_flags & DCACHE_REFERENCED)) {
dentry->d_flags &= ~DCACHE_REFERENCED;
list_move_tail(&dentry->d_lru, &referenced);
spin_unlock(&dentry->d_lock);
} else {
list_move_tail(&dentry->d_lru, &tmp);
spin_unlock(&dentry->d_lock);
- cnt--;
- if (!cnt)
+ if (--cnt == 0)
break;
}
}
@@ -504,10 +503,10 @@ restart:
/* dentry->d_lock was dropped in prune_one_dentry() */
cond_resched_lock(&dcache_lock);
}
- if (count == NULL && !list_empty(&sb->s_dentry_lru))
- goto restart;
- if (count != NULL)
+ if (count)
*count = cnt;
+ else if (!list_empty(&sb->s_dentry_lru))
+ goto restart;
if (!list_empty(&referenced))
list_splice(&referenced, &sb->s_dentry_lru);
spin_unlock(&dcache_lock);
next reply other threads:[~2008-06-24 1:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-24 1:45 Kentaro Makita [this message]
2008-06-24 2:07 ` [RESEND][PATCH -mm 1/2] vfs: fix coding style at dcache.c Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=486051AA.8000507@np.css.fujitsu.com \
--to=k-makita@np.css.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=harvey.harrison@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).