From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: linux-kernel@vger.kernel.org, hch@infradead.org,
linux-fsdevel@vger.kernel.org, ext-Adrian.Hunter@nokia.com
Subject: Re: Is VFS behavior fine?
Date: Wed, 02 Jul 2008 16:18:44 +0300 [thread overview]
Message-ID: <486B8034.1020904@nokia.com> (raw)
In-Reply-To: <E1KE07d-0007wx-M2@pomaz-ex.szeredi.hu>
Miklos Szeredi wrote:
>> I may just say that I fixed this in UBIFS by not calling
>> 'd_splice_alias()' for not found dentries if the parent
>> directory inode has 'n_link' = 0. However, ext[23] always
>> call 'd_splice_alias()' for not found direntries (passing
>> NULL as the 'inode' parameter).
>>
>> Again, I am not 100% sure this is the right fix, because
>> I suspect this should be "fixed" in VFS. I tried to do this
>> and I have a small VFS patch, but it is probably incorrect.
>
> The correct fix IMO is to make lookup return ENOENT on an IS_DEADDIR()
> inode, before even trying to create the child dentry.
Sounds correct, thanks for the replay.
> Untested patch attached.
Looks fine. Tried it, looks fine and solves my problem. Ran some
of my tests and they did not fail.
Hopefully this patch will make his way to mainline. Thanks.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-07-02 13:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-02 8:51 Is VFS behavior fine? Artem Bityutskiy
2008-07-02 11:03 ` Miklos Szeredi
2008-07-02 13:18 ` Artem Bityutskiy [this message]
2008-07-03 14:29 ` Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=486B8034.1020904@nokia.com \
--to=artem.bityutskiy@nokia.com \
--cc=ext-Adrian.Hunter@nokia.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).