From mboxrd@z Thu Jan  1 00:00:00 1970
From: Zach Brown <zach.brown@oracle.com>
Subject: Re: [PATCH] vfs: fix vfs_rename_dir for FS_RENAME_DOES_D_MOVE filesystems
Date: Fri, 18 Jul 2008 12:44:24 -0700
Message-ID: <4880F298.4010100@oracle.com>
References: <Pine.LNX.4.64.0807111236160.27059@cobra.newdream.net> <E1KHPcH-00076R-UD@pomaz-ex.szeredi.hu> <4877DAE6.9030405@oracle.com> <E1KJngd-0004sH-IP@pomaz-ex.szeredi.hu>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: sage@newdream.net, linux-fsdevel@vger.kernel.org,
	viro@ZenIV.linux.org.uk, akpm@linux-foundation.org,
	hch@infradead.org
To: Miklos Szeredi <miklos@szeredi.hu>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from tetsuo.zabbo.net ([207.173.201.20]:56647 "EHLO tetsuo.zabbo.net"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754557AbYGRToZ (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Fri, 18 Jul 2008 15:44:25 -0400
In-Reply-To: <E1KJngd-0004sH-IP@pomaz-ex.szeredi.hu>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

Miklos Szeredi wrote:
> On Fri, 11 Jul 2008, Zach Brown wrote:
>> Miklos Szeredi wrote:
>>> I think rehashing the new dentry is bogus, even on error.
>> So we'd just come back through lookup to repopulate the existing
>> destination name that vfs_rename_dir() unhashed before calling
>> ->rename() in the case that the rename fails?  That seems gross, but
>> relatively harmless.
> 
> We are talking about an _extremely_ rare event.

Agreed, which is why I called it relatively harmless.

- z