From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pekka Enberg Subject: Re: [patch 15/19] Filesystem: XFS slab defragmentation Date: Tue, 12 Aug 2008 10:08:07 +0300 Message-ID: <48A136D7.4080505@cs.helsinki.fi> References: <20080811150616.207532384@quilx.com> <20080811150659.051842926@quilx.com> <20080812002057.GH6119@disturbed> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit To: Christoph Lameter , Pekka Enberg , akpm@linux-foundation.org, Christoph Lameter , linux-kernel@vger.kernel.org, linu Return-path: Received: from courier.cs.helsinki.fi ([128.214.9.1]:38191 "EHLO mail.cs.helsinki.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751575AbYHLHLh (ORCPT ); Tue, 12 Aug 2008 03:11:37 -0400 In-Reply-To: <20080812002057.GH6119@disturbed> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Dave Chinner wrote: > On Mon, Aug 11, 2008 at 08:06:31AM -0700, Christoph Lameter wrote: >> Support inode defragmentation for xfs >> >> Reviewed-by: Rik van Riel >> Signed-off-by: Christoph Lameter >> Signed-off-by: Christoph Lameter >> >> --- >> fs/xfs/linux-2.6/xfs_super.c | 1 + >> 1 file changed, 1 insertion(+) >> >> Index: linux-next/fs/xfs/linux-2.6/xfs_super.c >> =================================================================== >> --- linux-next.orig/fs/xfs/linux-2.6/xfs_super.c 2008-08-11 07:42:11.892359719 -0700 >> +++ linux-next/fs/xfs/linux-2.6/xfs_super.c 2008-08-11 07:47:05.072348463 -0700 >> @@ -1947,6 +1947,7 @@ xfs_init_zones(void) >> xfs_ioend_zone = kmem_zone_init(sizeof(xfs_ioend_t), "xfs_ioend"); >> if (!xfs_ioend_zone) >> goto out_destroy_vnode_zone; >> + kmem_cache_setup_defrag(xfs_vnode_zone, get_inodes, kick_inodes); >> >> xfs_ioend_pool = mempool_create_slab_pool(4 * MAX_BUF_PER_PAGE, >> xfs_ioend_zone); > > Please update this patch as per my last comment. Christoph, I'm dropping this patch from my tree.