From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Lameter <cl@linux-foundation.org>
Subject: Re: SLUB defrag pull request?
Date: Mon, 13 Oct 2008 09:24:58 -0700
Message-ID: <48F3765A.2010301@linux-foundation.org>
References: <1223883004.31587.15.camel@penberg-laptop> <1223883164.31587.16.camel@penberg-laptop> <Pine.LNX.4.64.0810131227120.20511@blonde.site> <200810132354.30789.nickpiggin@yahoo.com.au> <E1KpNwq-0003OW-8f@pomaz-ex.szeredi.hu>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: nickpiggin@yahoo.com.au, hugh@veritas.com, linux-mm@kvack.org,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	penberg@cs.helsinki.fi, akpm@linux-foundation.org
To: Miklos Szeredi <miklos@szeredi.hu>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from smtp1.linux-foundation.org ([140.211.169.13]:48518 "EHLO
	smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1753992AbYJMOZb (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Mon, 13 Oct 2008 10:25:31 -0400
In-Reply-To: <E1KpNwq-0003OW-8f@pomaz-ex.szeredi.hu>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

Miklos Szeredi wrote:
> I think it's wrong to unhash dentries while they are possibly still
> being used.  You can do the shrink_dcache_parent() here, but should
> leave the unhashing to be done by prune_one_dentry(), after it's been
> checked that there are no other users of the dentry.
>
>   
d_invalidate() calls shrink_dcache_parent() as needed and will fail if 
there are other users of the dentry.