From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boaz Harrosh Subject: Re: [PATCH 02/14] quota: Increase size of variables for limits and inode usage Date: Tue, 28 Oct 2008 11:11:39 +0200 Message-ID: <4906D74B.1030001@panasas.com> References: <1225109512852-git-send-email-jack@suse.cz> <12251095123763-git-send-email-jack@suse.cz> <12251095124166-git-send-email-jack@suse.cz> <20081027224055.698a4ed6.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Jan Kara , linux-fsdevel@vger.kernel.org To: Andrew Morton Return-path: Received: from gw-ca.panasas.com ([66.104.249.162]:23615 "EHLO laguna.int.panasas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751614AbYJ1JLo (ORCPT ); Tue, 28 Oct 2008 05:11:44 -0400 In-Reply-To: <20081027224055.698a4ed6.akpm@linux-foundation.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Andrew Morton wrote: > On Mon, 27 Oct 2008 13:11:40 +0100 Jan Kara wrote: > > > Also, qsize_t is typedefed to a __u64. But u64's are a pain because > people keep trying to print them and they often forget the typecast > and they cause warning storms. > > > So until that gets fixed it'd be good to just do > > typedef unsigned long long qsize_t; > > which I think we can trivally do? > > > Why does qsize_t exist, anyway? It's always going to be 64-bit, so why > not open-code `unsigned long long' everywhere. Or u64? > > I guess it has some readability benefit in certain cases. It'd be a > damn sight more useful if we also got compiler typechecking for such > typedefs, but such is C... > There is always that: typedef unsigned long long __bitwise qsize_t; And that special "sparse" compiler. So I guess it would be checked by some people Boaz