From: Ric Wheeler <rwheeler@redhat.com>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Andreas Dilger <adilger@sun.com>, Josef Bacik <jbacik@redhat.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH] improve jbd fsync batching
Date: Tue, 28 Oct 2008 17:56:39 -0400 [thread overview]
Message-ID: <49078A97.8020003@redhat.com> (raw)
In-Reply-To: <20081028144401.07b7546d@infradead.org>
Arjan van de Ven wrote:
> On Tue, 28 Oct 2008 15:38:05 -0600
> Andreas Dilger <adilger@sun.com> wrote:
>
>
>> On Oct 28, 2008 16:16 -0400, Josef Bacik wrote:
>>
>>> I also have a min() check in there to make sure we don't sleep
>>> longer than a jiffie in case our storage is super slow, this was
>>> requested by Andrew.
>>>
>> Is there a particular reason why 1 jiffie is considered the "right
>> amount" of time to sleep, given this is a kernel config parameter and
>> has nothing to do with the storage? Considering a seek time in the
>> range of ~10ms this would only be right for HZ=100 and the wait would
>>
>
> well... my disk does a 50 usec seek time or so.. so I don't mind ;-)
>
> in fact it sounds awefully long to me.
>
For small writes as well as reads?
If so, it would be great to test Josef's patch against your shiny new
SSD :-)
ric
next prev parent reply other threads:[~2008-10-28 21:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-28 20:16 [PATCH] improve jbd fsync batching Josef Bacik
2008-10-28 21:38 ` Andreas Dilger
2008-10-28 21:33 ` Josef Bacik
2008-10-28 21:44 ` Arjan van de Ven
2008-10-28 21:56 ` Ric Wheeler [this message]
2008-11-03 20:27 ` Andrew Morton
2008-11-03 20:24 ` Josef Bacik
2008-11-03 20:55 ` Andrew Morton
2008-11-04 15:41 ` Josef Bacik
2008-11-03 22:13 ` Theodore Tso
2008-11-04 5:24 ` Andreas Dilger
2008-11-04 9:12 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49078A97.8020003@redhat.com \
--to=rwheeler@redhat.com \
--cc=adilger@sun.com \
--cc=arjan@infradead.org \
--cc=jbacik@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).