From: Timothy Shimmin <tes@sgi.com>
To: Christoph Hellwig <hch@lst.de>
Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] remove incorrect comment in inode_permission
Date: Thu, 06 Nov 2008 14:47:24 +1100 [thread overview]
Message-ID: <491268CC.2000401@sgi.com> (raw)
In-Reply-To: <20081105140429.GB5012@lst.de>
Christoph Hellwig wrote:
> We now pass on all MAY_ flags to the filesystems permission routines,
> so remove the comment stating the contrary.
>
Looks good.
Looks like an oversight from when the submask and MAY_APPEND clearing
lines of code were taken out.
Reviewed-by: Tim Shimmin <tes@sgi.com>
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Index: linux-2.6/fs/namei.c
> ===================================================================
> --- linux-2.6.orig/fs/namei.c 2008-11-04 12:24:15.000000000 +0100
> +++ linux-2.6/fs/namei.c 2008-11-04 12:24:38.000000000 +0100
> @@ -257,7 +257,6 @@ int inode_permission(struct inode *inode
> return -EACCES;
> }
>
> - /* Ordinary permission routines do not understand MAY_APPEND. */
> if (inode->i_op && inode->i_op->permission)
> retval = inode->i_op->permission(inode, mask);
> else
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2008-11-06 3:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-05 14:04 [PATCH] remove incorrect comment in inode_permission Christoph Hellwig
2008-11-06 3:47 ` Timothy Shimmin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=491268CC.2000401@sgi.com \
--to=tes@sgi.com \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).