* [PATCH] remove incorrect comment in inode_permission
@ 2008-11-05 14:04 Christoph Hellwig
2008-11-06 3:47 ` Timothy Shimmin
0 siblings, 1 reply; 2+ messages in thread
From: Christoph Hellwig @ 2008-11-05 14:04 UTC (permalink / raw)
To: viro; +Cc: linux-fsdevel
We now pass on all MAY_ flags to the filesystems permission routines,
so remove the comment stating the contrary.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: linux-2.6/fs/namei.c
===================================================================
--- linux-2.6.orig/fs/namei.c 2008-11-04 12:24:15.000000000 +0100
+++ linux-2.6/fs/namei.c 2008-11-04 12:24:38.000000000 +0100
@@ -257,7 +257,6 @@ int inode_permission(struct inode *inode
return -EACCES;
}
- /* Ordinary permission routines do not understand MAY_APPEND. */
if (inode->i_op && inode->i_op->permission)
retval = inode->i_op->permission(inode, mask);
else
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] remove incorrect comment in inode_permission
2008-11-05 14:04 [PATCH] remove incorrect comment in inode_permission Christoph Hellwig
@ 2008-11-06 3:47 ` Timothy Shimmin
0 siblings, 0 replies; 2+ messages in thread
From: Timothy Shimmin @ 2008-11-06 3:47 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: viro, linux-fsdevel
Christoph Hellwig wrote:
> We now pass on all MAY_ flags to the filesystems permission routines,
> so remove the comment stating the contrary.
>
Looks good.
Looks like an oversight from when the submask and MAY_APPEND clearing
lines of code were taken out.
Reviewed-by: Tim Shimmin <tes@sgi.com>
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Index: linux-2.6/fs/namei.c
> ===================================================================
> --- linux-2.6.orig/fs/namei.c 2008-11-04 12:24:15.000000000 +0100
> +++ linux-2.6/fs/namei.c 2008-11-04 12:24:38.000000000 +0100
> @@ -257,7 +257,6 @@ int inode_permission(struct inode *inode
> return -EACCES;
> }
>
> - /* Ordinary permission routines do not understand MAY_APPEND. */
> if (inode->i_op && inode->i_op->permission)
> retval = inode->i_op->permission(inode, mask);
> else
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-11-06 3:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-05 14:04 [PATCH] remove incorrect comment in inode_permission Christoph Hellwig
2008-11-06 3:47 ` Timothy Shimmin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).