From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timothy Shimmin Subject: Re: [PATCH] remove incorrect comment in inode_permission Date: Thu, 06 Nov 2008 14:47:24 +1100 Message-ID: <491268CC.2000401@sgi.com> References: <20081105140429.GB5012@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org To: Christoph Hellwig Return-path: Received: from netops-testserver-3-out.sgi.com ([192.48.171.28]:41998 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751870AbYKFDr2 (ORCPT ); Wed, 5 Nov 2008 22:47:28 -0500 In-Reply-To: <20081105140429.GB5012@lst.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Christoph Hellwig wrote: > We now pass on all MAY_ flags to the filesystems permission routines, > so remove the comment stating the contrary. > Looks good. Looks like an oversight from when the submask and MAY_APPEND clearing lines of code were taken out. Reviewed-by: Tim Shimmin > > Signed-off-by: Christoph Hellwig > > Index: linux-2.6/fs/namei.c > =================================================================== > --- linux-2.6.orig/fs/namei.c 2008-11-04 12:24:15.000000000 +0100 > +++ linux-2.6/fs/namei.c 2008-11-04 12:24:38.000000000 +0100 > @@ -257,7 +257,6 @@ int inode_permission(struct inode *inode > return -EACCES; > } > > - /* Ordinary permission routines do not understand MAY_APPEND. */ > if (inode->i_op && inode->i_op->permission) > retval = inode->i_op->permission(inode, mask); > else > -- > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html