From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79CF9EB64D9 for ; Thu, 6 Jul 2023 11:47:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232320AbjGFLrr (ORCPT ); Thu, 6 Jul 2023 07:47:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229654AbjGFLrq (ORCPT ); Thu, 6 Jul 2023 07:47:46 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8184D124; Thu, 6 Jul 2023 04:47:45 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0954561908; Thu, 6 Jul 2023 11:47:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 97B0AC433C7; Thu, 6 Jul 2023 11:47:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688644064; bh=CcRPw0eryDk6Uzi3dfXUi3cnjVTZ76trI3a28Kui0gw=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=PI0pqoQlg4ZtdxNuQhusA2J7TMuOk+nkP3fwX4IM+xcAZ6wHKTYSvkYBxcR7+pc9H cjJgu5tkDMC+VrT1jOg3aM/vqEqnrM8LIg6lfjUoYG3Ds/cYasSP+t7wRHWMD1Qk4k O19MxH86UWt2p9Q17ex3rdVdQgYyNYuL+8d3fHnZ3nngfXAOImdE11AgirhZQ6wiJ7 qNyj6cNU3khptBz+wzOWArr09GSkI1lxpR4Wr9aZzj0sdJ+Uejn4u0uFYzJ+b43ikV yvQkSQwdN2CKqxBIibVq9dJsHZJybz/7FA3Oj2iIwzlXAOuPqlwlA2nJV/r3UhwKOX ZEL3xOez9dnBA== Message-ID: <491b4b44e76ec9d52fe1dbe840c9820dc6713a39.camel@kernel.org> Subject: Re: [PATCH v2 30/92] ceph: convert to ctime accessor functions From: Jeff Layton To: Jan Kara Cc: Christian Brauner , Xiubo Li , Ilya Dryomov , Al Viro , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, ceph-devel@vger.kernel.org Date: Thu, 06 Jul 2023 07:47:42 -0400 In-Reply-To: <20230706105345.cdoadx7hvb227vts@quack3> References: <20230705185755.579053-1-jlayton@kernel.org> <20230705190309.579783-1-jlayton@kernel.org> <20230705190309.579783-28-jlayton@kernel.org> <20230706105345.cdoadx7hvb227vts@quack3> Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, 2023-07-06 at 12:53 +0200, Jan Kara wrote: > On Wed 05-07-23 15:00:55, Jeff Layton wrote: > > In later patches, we're going to change how the inode's ctime field is > > used. Switch to using accessor functions instead of raw accesses of > > inode->i_ctime. > >=20 > > Reviewed-by: Xiubo Li > > Signed-off-by: Jeff Layton >=20 > Just one nit below: >=20 > > @@ -688,6 +688,7 @@ void ceph_fill_file_time(struct inode *inode, int i= ssued, > > struct timespec64 *mtime, struct timespec64 *atime) > > { > > struct ceph_inode_info *ci =3D ceph_inode(inode); > > + struct timespec64 ictime =3D inode_get_ctime(inode); > > int warn =3D 0; > > =20 > > if (issued & (CEPH_CAP_FILE_EXCL| > > @@ -696,11 +697,12 @@ void ceph_fill_file_time(struct inode *inode, int= issued, > > CEPH_CAP_AUTH_EXCL| > > CEPH_CAP_XATTR_EXCL)) { > > if (ci->i_version =3D=3D 0 || > > - timespec64_compare(ctime, &inode->i_ctime) > 0) { > > + timespec64_compare(ctime, &ictime) > 0) { > > dout("ctime %lld.%09ld -> %lld.%09ld inc w/ cap\n", > > - inode->i_ctime.tv_sec, inode->i_ctime.tv_nsec, > > + inode_get_ctime(inode).tv_sec, > > + inode_get_ctime(inode).tv_nsec, >=20 > I think here you can use ictime instead of inode_get_ctime(inode). > Otherwise feel free to add: >=20 > Reviewed-by: Jan Kara >=20 Thanks. Fixed in my tree. --=20 Jeff Layton