From: Avi Kivity <avi@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: kvm@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH/RFC 2] kvm: fix module refcount issues with anon_inodegetfd
Date: Tue, 25 Nov 2008 15:55:57 +0200 [thread overview]
Message-ID: <492C03ED.1090808@redhat.com> (raw)
In-Reply-To: <200811250907.54042.borntraeger@de.ibm.com>
Christian Borntraeger wrote:
>> Messing with module counts is slightly ugly.
>>
>
> I changed my patch to be more generic. Instead of messing with the
> module refcount in the kvm module, I decided to change
> anon_inode_getfd instead. If the owner field is set, we will
> try an module_get in anon_inode_getfd, since the VFS release
> function will do a module_put. This makes the open/release
> symmetric. What do you think?
>
I agree with your analysis, and also that the anon_inodes change is
useful. If it's acceptable to the vfs/anon_inode maintainers, I'll
apply the patch.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2008-11-25 13:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200811202010.00125.borntraeger@de.ibm.com>
[not found] ` <49295F6D.8010200@redhat.com>
2008-11-25 8:07 ` [PATCH/RFC 2] kvm: fix module refcount issues with anon_inodegetfd Christian Borntraeger
2008-11-25 13:55 ` Avi Kivity [this message]
2008-11-27 14:01 ` [PATCH/Request for review]: check for fops->owner in anon_inode_getfd Christian Borntraeger
2008-11-27 18:49 ` Davide Libenzi
2008-11-27 19:17 ` [PATCH v2]: " Christian Borntraeger
2008-11-27 19:40 ` Davide Libenzi
2008-12-01 8:57 ` Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=492C03ED.1090808@redhat.com \
--to=avi@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).