[PATCH] fs: use menuconfig to control the Misc. filesystems menu

[PATCH] fs: use menuconfig to control the Misc. filesystems menu

[Randy Dunlap]

Subject:   [PATCH] fs: use menuconfig to control the Misc. filesystems menu
To:        linux-fsdevel@vger.kernel.org
Cc:        akpm <akpm@linux-foundation.org>,Al Viro <viro@zeniv.linux.org.uk>
Bcc:       
 =-=-=-=-=-=-=-=-=# Don't remove this line #=-=-=-=-=-=-=-=-=-
From: Randy Dunlap <randy.dunlap@oracle.com>

Have one option to control Miscellaneous filesystems.
This makes it easy to disable all of them at one time.

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---

Was this already attempted?  If so, was there any problem with it?

 fs/Kconfig |   17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)

--- linux-next-20081125.orig/fs/Kconfig
+++ linux-next-20081125/fs/Kconfig
@@ -758,7 +758,20 @@ config CONFIGFS_FS
 
 endmenu
 
-menu "Miscellaneous filesystems"
+menuconfig MISC_FILESYSTEMS
+	bool "Miscellaneous filesystems"
+	default y
+	---help---
+	  Say Y here to get to see options for various miscellaneous
+	  filesystems, such as filesystems that came from other
+	  operating systems.
+
+	  This option alone does not add any kernel code.
+
+	  If you say N, all options in this submenu will be skipped and
+	  disabled; if unsure, say Y here.
+
+if MISC_FILESYSTEMS
 
 config ADFS_FS
 	tristate "ADFS file system support (EXPERIMENTAL)"
@@ -1128,7 +1141,7 @@ config UFS_DEBUG
 	  Y here.  This will result in _many_ additional debugging messages to be
 	  written to the system log.
 
-endmenu
+endif # MISC_FILESYSTEMS
 
 menuconfig NETWORK_FILESYSTEMS
 	bool "Network File Systems"

Re: [PATCH] fs: use menuconfig to control the Misc. filesystems menu

[Phillip Lougher]

Randy Dunlap wrote:

> Have one option to control Miscellaneous filesystems.
> This makes it easy to disable all of them at one time.

> -menu "Miscellaneous filesystems"
> +menuconfig MISC_FILESYSTEMS
> +	bool "Miscellaneous filesystems"
> +	default y
> +	---help---
> +	  Say Y here to get to see options for various miscellaneous
> +	  filesystems, such as filesystems that came from other
> +	  operating systems.
> +

I have no particular issue against adding this option, but the help 
message is misleading.  The miscellaneous submenu also contains (mainly) 
embedded filesystems such as jffs2, cramfs, romfs and eCrypt which are 
native to Linux.

The help message should be changed, or perhaps these filesystems moved 
into a new submenu of their own.

Phillip

Re: [PATCH] fs: use menuconfig to control the Misc. filesystems menu

[Randy Dunlap]

Phillip Lougher wrote:
> Randy Dunlap wrote:
> 
>> Have one option to control Miscellaneous filesystems.
>> This makes it easy to disable all of them at one time.
> 
>> -menu "Miscellaneous filesystems"
>> +menuconfig MISC_FILESYSTEMS
>> +    bool "Miscellaneous filesystems"
>> +    default y
>> +    ---help---
>> +      Say Y here to get to see options for various miscellaneous
>> +      filesystems, such as filesystems that came from other
>> +      operating systems.
>> +
> 
> I have no particular issue against adding this option, but the help
> message is misleading.  The miscellaneous submenu also contains (mainly)
> embedded filesystems such as jffs2, cramfs, romfs and eCrypt which are
> native to Linux.
> 
> The help message should be changed, or perhaps these filesystems moved
> into a new submenu of their own.
> 
> Phillip

OK, I'll be glad to change the help message.  (awaiting other comments)

Thanks.