From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01B02C282C3 for ; Thu, 24 Jan 2019 11:01:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C79BC218A2 for ; Thu, 24 Jan 2019 11:01:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727507AbfAXLBO (ORCPT ); Thu, 24 Jan 2019 06:01:14 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:51366 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727455AbfAXLBN (ORCPT ); Thu, 24 Jan 2019 06:01:13 -0500 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 4343347E4F88B32D2DDF; Thu, 24 Jan 2019 19:01:11 +0800 (CST) Received: from [127.0.0.1] (10.177.31.14) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.408.0; Thu, 24 Jan 2019 19:01:04 +0800 Subject: Re: [PATCH v3 1/2] 9p: use inode->i_lock to protect i_size_write() under 32-bit To: Dominique Martinet CC: , , , , References: <20190124063514.8571-1-houtao1@huawei.com> <20190124063514.8571-2-houtao1@huawei.com> <20190124065733.GA21444@nautica> From: Hou Tao Message-ID: <494336cc-ebf2-3763-b60e-d4e50a199380@huawei.com> Date: Thu, 24 Jan 2019 19:01:03 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20190124065733.GA21444@nautica> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.31.14] X-CFilter-Loop: Reflected Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Hi, On 2019/1/24 14:57, Dominique Martinet wrote: > Hou Tao wrote on Thu, Jan 24, 2019: >> @@ -83,4 +88,17 @@ static inline void v9fs_invalidate_inode_attr(struct inode *inode) >> } >> >> int v9fs_open_to_dotl_flags(int flags); >> + >> +static inline void v9fs_i_size_write(struct inode *inode, loff_t i_size) >> +{ >> + /* >> + * Avoid taking i_lock under 64-bit. >> + * Refer to fsstack_copy_inode_size() for detailed explanation. >> + */ > > Just one last nitpick here: I'd rather not reference to another function > for comment; the 9p code doesn't change much and if someone ever changes > fsstack_copy_inode_size it'll probably go unnoticed for a while. > > If you're OK with this I can change it myself, but got other comments > for second patch so up to you. Please help to change it, thanks. I will update the second patch accordingly or let it referring to v9fs_i_size_write :) Regards, Tao > > More than happy with the rest, I'll run some tests over the weekend for > the sake of it but should take this patch to -next early next week > assuming we agree on something for the comment. >