linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@kernel.org>
To: Chuck Lever III <chuck.lever@oracle.com>, Dai Ngo <dai.ngo@oracle.com>
Cc: Bruce Fields <bfields@fieldses.org>,
	Al Viro <viro@zeniv.linux.org.uk>,
	Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH RFC v13 1/4] fs/lock: documentation cleanup. Replace inode->i_lock with flc_lock.
Date: Mon, 14 Feb 2022 12:24:52 -0500	[thread overview]
Message-ID: <496629d25936838bf6e64dcae0e1210c8ed1fcb1.camel@kernel.org> (raw)
In-Reply-To: <8EF5C08B-E6C9-4B3D-B26C-1088B0130BEF@oracle.com>

On Mon, 2022-02-14 at 17:03 +0000, Chuck Lever III wrote:
> 
> > On Feb 12, 2022, at 1:12 PM, Dai Ngo <dai.ngo@oracle.com> wrote:
> > 
> > Update lock usage of lock_manager_operations' functions.
> > 
> > Signed-off-by: Dai Ngo <dai.ngo@oracle.com>
> 
> I can apply this one to the nfsd tree if Jeff acks it.
> 
> Also I think I want to amend the commit description to mention
> 6109c85037e5 ("locks: add a dedicated spinlock to protect i_flctx lists"),
> which is the commit that did the locking conversion, if that's
> OK with everyone.
> 
> 

Works for me.

> > ---
> > Documentation/filesystems/locking.rst | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/Documentation/filesystems/locking.rst b/Documentation/filesystems/locking.rst
> > index 3f9b1497ebb8..aaca0b601819 100644
> > --- a/Documentation/filesystems/locking.rst
> > +++ b/Documentation/filesystems/locking.rst
> > @@ -438,13 +438,13 @@ prototypes::
> > locking rules:
> > 
> > ======================	=============	=================	=========
> > -ops			inode->i_lock	blocked_lock_lock	may block
> > +ops			   flc_lock  	blocked_lock_lock	may block
> > ======================	=============	=================	=========
> > -lm_notify:		yes		yes			no
> > +lm_notify:		no      	yes			no
> > lm_grant:		no		no			no
> > lm_break:		yes		no			no
> > lm_change		yes		no			no
> > -lm_breaker_owns_lease:	no		no			no
> > +lm_breaker_owns_lease:	yes     	no			no
> > ======================	=============	=================	=========
> > 
> > buffer_head
> > -- 
> > 2.9.5
> > 
> 
> --
> Chuck Lever
> 
> 
> 

Reviewed-by: Jeff Layton <jlayton@kernel.org>

  reply	other threads:[~2022-02-14 17:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-12 18:12 [PATCH RFC v13 0/4] nfsd: Initial implementation of NFSv4 Courteous Server Dai Ngo
2022-02-12 18:12 ` [PATCH RFC v13 1/4] fs/lock: documentation cleanup. Replace inode->i_lock with flc_lock Dai Ngo
2022-02-14 17:03   ` Chuck Lever III
2022-02-14 17:24     ` Jeff Layton [this message]
2022-02-12 18:12 ` [PATCH RFC v13 2/4] fs/lock: add new callback, lm_lock_expired, to lock_manager_operations Dai Ngo
2022-02-12 18:12 ` [PATCH RFC v13 3/4] fs/lock: only call lm_breaker_owns_lease if there is conflict Dai Ngo
2022-02-12 18:12 ` [PATCH RFC v13 4/4] nfsd: Initial implementation of NFSv4 Courteous Server Dai Ngo
2022-02-15 17:17   ` Chuck Lever III
2022-02-16  9:56     ` dai.ngo
2022-02-16 16:15       ` Chuck Lever III
2022-02-18 18:03         ` dai.ngo
2022-02-18 18:28           ` Chuck Lever III

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=496629d25936838bf6e64dcae0e1210c8ed1fcb1.camel@kernel.org \
    --to=jlayton@kernel.org \
    --cc=bfields@fieldses.org \
    --cc=chuck.lever@oracle.com \
    --cc=dai.ngo@oracle.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).