From: Arjan van de Ven <arjan@linux.intel.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Dave Kleikamp <shaggy@linux.vnet.ibm.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Grissiom <chaos.proton@gmail.com>,
linux-kernel@vger.kernel.org,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH] async: Don't call async_synchronize_full_special() while holding sb_lock
Date: Thu, 08 Jan 2009 16:38:40 -0800 [thread overview]
Message-ID: <49669C90.9070503@linux.intel.com> (raw)
In-Reply-To: <20090109003239.06f73bd1@lxorguk.ukuu.org.uk>
Alan Cox wrote:
> On Thu, 08 Jan 2009 14:51:52 -0800
> Arjan van de Ven <arjan@linux.intel.com> wrote:
>
>> Dave Chinner wrote:
>>> On Thu, Jan 08, 2009 at 09:46:31AM -0600, Dave Kleikamp wrote:
>>>> sync_filesystems() shouldn't be calling async_synchronize_full_special
>>>> while holding a spinlock. The second while loop in that function is the
>>>> right place for this anyway.
>>> Out of curiousity, what on earth does
>>> async_synchronize_full_special() do and why does it need to be in
>>> sync_filesystems()?
>>>
>> now that we have asynchronous operations, this function makes sure that all the functions
>> that we started async before this point complete, so that what when you sync, you sync all in progress work.
>
> So why is it special - wouldn't async_synchronize_all() be a bit (or
> complete_all) be a bit more clear ?
there is 2 types; one synchronizes the global kernel events
one is special in that it only synchronizes the events you give it (via a list head)
next prev parent reply other threads:[~2009-01-09 0:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <a0adeea50901080007q5a3ed5c8y5a744ce37e677325@mail.gmail.com>
2009-01-08 14:37 ` "BUG: scheduling while atomic: pdflush/30/0x00000002" in latest git Dave Kleikamp
2009-01-08 15:21 ` Arjan van de Ven
2009-01-08 15:46 ` [PATCH] async: Don't call async_synchronize_full_special() while holding sb_lock Dave Kleikamp
2009-01-08 22:50 ` Dave Chinner
2009-01-08 22:51 ` Arjan van de Ven
2009-01-09 0:32 ` Alan Cox
2009-01-09 0:38 ` Arjan van de Ven [this message]
2009-01-09 1:40 ` Dave Chinner
2009-01-09 4:45 ` Arjan van de Ven
2009-01-09 8:22 ` Dave Chinner
2009-01-09 15:09 ` Chris Mason
2009-01-12 2:31 ` Jamie Lokier
2009-01-12 3:54 ` Arjan van de Ven
2009-01-12 7:55 ` Dave Chinner
2009-01-12 7:48 ` Dave Chinner
2009-01-09 12:31 ` Evgeniy Polyakov
2009-01-09 5:18 ` "BUG: scheduling while atomic: pdflush/30/0x00000002" in latest git Grissiom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49669C90.9070503@linux.intel.com \
--to=arjan@linux.intel.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=chaos.proton@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shaggy@linux.vnet.ibm.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).