From mboxrd@z Thu Jan 1 00:00:00 1970 From: "H. Peter Anvin" Subject: Re: [PATCH -v7][RFC]: mutex: implement adaptive spinning Date: Thu, 08 Jan 2009 21:05:46 -0800 Message-ID: <4966DB2A.6030708@zytor.com> References: <1231365115.11687.361.camel@twins> <1231366716.11687.377.camel@twins> <1231408718.11687.400.camel@twins> <20090108141808.GC11629@elte.hu> <1231426014.11687.456.camel@twins> <1231434515.14304.27.camel@think.oraclecorp.com> <20090108183306.GA22916@elte.hu> <1231444786.5715.8.camel@brick> <4966ABF9.9080409@zytor.com> <1231467896.5715.40.camel@brick> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Ingo Molnar , Linus Torvalds , Chris Mason , Peter Zijlstra , Steven Rostedt , paulmck@linux.vnet.ibm.com, Gregory Haskins , Matthew Wilcox , Andi Kleen , Andrew Morton , Linux Kernel Mailing List , linux-fsdevel , linux-btrfs , Thomas Gleixner , Nick Piggin , Peter Morreale , Sven Dietrich To: Harvey Harrison Return-path: Received: from terminus.zytor.com ([198.137.202.10]:34147 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751700AbZAIFPq (ORCPT ); Fri, 9 Jan 2009 00:15:46 -0500 In-Reply-To: <1231467896.5715.40.camel@brick> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Harvey Harrison wrote: > > A lot of code was written assuming inline means __always_inline, I'd suggest > keeping that assumption and working on removing inlines that aren't > strictly necessary as there's no way to know what inlines meant 'try to inline' > and what ones really should have been __always_inline. > > Not that I feel _that_ strongly about it. > Actually, we have that reasonably well down by now. There seems to be a couple of minor tweaking still necessary, but I think we're 90-95% there already. -hpa -- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf.