linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ric Wheeler <rwheeler@redhat.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
	David Woodhouse <dwmw2@infradead.org>,
	"Martin K. Petersen" <mkp@mkp.net>, Jeff Garzik <jeff@garzik.org>,
	linux-scsi@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	IDE/ATA development list <linux-ide@vger.kernel.org>
Subject: Re: TRIM vs UNMAP vs WRITE SAME and thin devices
Date: Sun, 08 Feb 2009 18:58:22 -0500	[thread overview]
Message-ID: <498F719E.6090709@redhat.com> (raw)
In-Reply-To: <20090208205049.GG31509@parisc-linux.org>

Matthew Wilcox wrote:
> On Sun, Feb 08, 2009 at 11:47:25AM -0500, Ric Wheeler wrote:
>   
>> Matthew Wilcox wrote:
>>     
>>> I thought we had agreed on a plan which satisfied the SSD and insane
>>> array vendors.  That is that we would do no tracking of allocation units
>>> in the filesystem, but instead extend each trim out to cover the maximum
>>> possible size.  I've confirmed with Intel's SSD people that this would
>>> cause them no harm at all (trimming already trimmed sectors won't even
>>> cause a slowdown).  Whether the filesystem people have taken note of
>>> this, I have no idea.
>>>       
>> That should be helpful for the array people, but for some of them with 
>> really large delete chuck sizes, they will still miss a lot since their 
>> size is larger than the average file size :-)  I guess that we could do 
>> something to resync - Ted mentioned some ideas for ext4.
>>     
>
> I'm not sure I communicated the plan effectively.
>
> Let's consider deleting a 4k file.
>
> The DISCARD that the filesystem sends down does not just cover the 4k
> of data.  It covers all adjacent free space to that 4k of data, so it
> might end up sending a DISCARD of several megabytes or even gigabytes,
> assuming there's that much contiguous free space.
>
> Now, filesystems which fragment their free space will not do well on
> thin provisioned devices, but then they won't do well on any devices --
> keeping your free space compacted is an essential part of any filesystem's
> job, even on SSDs.
>
>   
Thanks - that does sound like it will in fact help clean up.  I suppose 
the worst case would be deleting lots of non-contiguous small files from 
a full file system (say every other 4KB or something obscure like that). 

I will see what the vendors I know have come up with, I think that this 
should give them something interesting to play with....

Ric



  reply	other threads:[~2009-02-08 23:58 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20090123041558.GC24652@parisc-linux.org>
     [not found] ` <4979AF62.7070409@redhat.com>
     [not found]   ` <1232721777.4430.7.camel@macbook.infradead.org>
2009-02-07 14:53     ` TRIM vs UNMAP vs WRITE SAME and thin devices Ric Wheeler
2009-02-07 15:09       ` James Bottomley
2009-02-07 16:14         ` Ric Wheeler
2009-02-12 13:51           ` Eyal Shani
2009-03-23 19:05             ` Greg Freemyer
2009-03-23 19:23               ` Mark Lord
2009-02-07 22:50         ` Matthew Wilcox
2009-02-07 23:03           ` James Bottomley
2009-02-08 16:47           ` Ric Wheeler
2009-02-08 20:50             ` Matthew Wilcox
2009-02-08 23:58               ` Ric Wheeler [this message]
2009-02-07 22:47       ` Matthew Wilcox
2009-02-07 23:36         ` David Woodhouse
2009-02-07 23:46         ` Jeff Garzik
2009-02-08  0:24           ` Matthew Wilcox
2009-02-08 20:06       ` Greg Freemyer
2009-02-08 20:44         ` Matthew Wilcox
2009-02-09  0:01           ` Ric Wheeler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=498F719E.6090709@redhat.com \
    --to=rwheeler@redhat.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=dwmw2@infradead.org \
    --cc=jeff@garzik.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=mkp@mkp.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).