From mboxrd@z Thu Jan  1 00:00:00 1970
From: Zach Brown <zach.brown@oracle.com>
Subject: Re: [patch][rfc] mm: hold page lock over page_mkwrite
Date: Wed, 25 Feb 2009 08:58:06 -0800
Message-ID: <49A5789E.4040600@oracle.com>
References: <20090225093629.GD22785@wotan.suse.de> <49A5750A.1080006@oracle.com> <20090225165501.GK22785@wotan.suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: linux-fsdevel@vger.kernel.org,
	Linux Memory Management List <linux-mm@kvack.org>,
	Mark Fasheh <mfasheh@suse.com>, Sage Weil <sage@newdream.net>
To: Nick Piggin <npiggin@suse.de>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from tetsuo.zabbo.net ([207.173.201.20]:38512 "EHLO tetsuo.zabbo.net"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750966AbZBYQ6K (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Wed, 25 Feb 2009 11:58:10 -0500
In-Reply-To: <20090225165501.GK22785@wotan.suse.de>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>


> Is ocfs2 immune to the races that get covered by this patch?

I haven't the slightest idea.

> Hmm, actually possibly we can enter page_mkwrite with the page unlocked,
> but exit with the page locked? Slightly more complex, but should save
> complexity elsewhere. Yes I think this might be the best way to go.

That sounds like it would work on first glance, yeah.  Mark will yell at
us if we've gotten it wrong ;).

- z