From mboxrd@z Thu Jan  1 00:00:00 1970
From: Boaz Harrosh <bharrosh@panasas.com>
Subject: Re: [PATCH 2/8] exofs: file and file_inode operations
Date: Tue, 31 Mar 2009 11:58:42 +0300
Message-ID: <49D1DB42.3020903@panasas.com>
References: <49C1331D.1080805@panasas.com>	<1237399127-29206-1-git-send-email-bharrosh@panasas.com> <20090331010417.43deb1e7.akpm@linux-foundation.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: Avishay Traeger <avishay@gmail.com>, Jeff Garzik <jeff@garzik.org>,
	Evgeniy Polyakov <zbr@ioremap.net>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	open-osd <osd-dev@open-osd.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	James Bottomley <James.Bottomley@HansenPartnership.com>,
	FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
To: Andrew Morton <akpm@linux-foundation.org>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from gw-ca.panasas.com ([209.116.51.66]:13418 "EHLO
	laguna.int.panasas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
	with ESMTP id S1754173AbZCaJAm (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Tue, 31 Mar 2009 05:00:42 -0400
In-Reply-To: <20090331010417.43deb1e7.akpm@linux-foundation.org>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On 03/31/2009 11:04 AM, Andrew Morton wrote:
> On Wed, 18 Mar 2009 19:58:47 +0200 Boaz Harrosh <bharrosh@panasas.com> wrote:
> 
>> implementation of the file_operations and inode_operations for
>> regular data files.
>>
>> Most file_operations are generic vfs implementations except:
>> - exofs_truncate will truncate the OSD object as well
>> - Generic file_fsync is not good for none_bd devices so open code it
>> - The default for .flush in Linux is todo nothing so call exofs_fsync
>>   on the file.
>>
>>
>> ...
>>
>> +static int exofs_file_fsync(struct file *filp, struct dentry *dentry,
>> +			    int datasync)
>> +{
>> +	int ret1, ret2;
>> +	struct address_space *mapping = filp->f_mapping;
>> +
>> +	ret1 = filemap_write_and_wait(mapping);
>> +	ret2 = file_fsync(filp, dentry, datasync);
>> +
>> +	return ret1 ? ret1 : ret2;
>> +}
> 
> It might be better to abort if filemap_write_and_wait() failed.  if the
> hardware is bad, these things can take a looooong time retrying and
> timing out.  There's no point in doubling the delay.
> 
>> ...
>>
> 

OK I got confused by existing code, good point
Boaz