From mboxrd@z Thu Jan  1 00:00:00 1970
From: Boaz Harrosh <bharrosh@panasas.com>
Subject: Re: [PATCH 4/8 ver5] exofs: address_space_operations
Date: Tue, 31 Mar 2009 12:04:36 +0300
Message-ID: <49D1DCA4.6010306@panasas.com>
References: <49C1331D.1080805@panasas.com>	<1237399473-29344-1-git-send-email-bharrosh@panasas.com>	<49C64416.4060801@panasas.com> <20090331010420.8a12810e.akpm@linux-foundation.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: Avishay Traeger <avishay@gmail.com>, Jeff Garzik <jeff@garzik.org>,
	Evgeniy Polyakov <zbr@ioremap.net>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	open-osd <osd-dev@open-osd.org>,
	Marcin Slusarz <marcin.slusarz@gmail.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	James Bottomley <James.Bottomley@HansenPartnership.com>,
	FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
To: Andrew Morton <akpm@linux-foundation.org>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from gw-ca.panasas.com ([209.116.51.66]:10001 "EHLO
	laguna.int.panasas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
	with ESMTP id S1754439AbZCaJGh (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Tue, 31 Mar 2009 05:06:37 -0400
In-Reply-To: <20090331010420.8a12810e.akpm@linux-foundation.org>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On 03/31/2009 11:04 AM, Andrew Morton wrote:
> On Sun, 22 Mar 2009 15:58:46 +0200 Boaz Harrosh <bharrosh@panasas.com> wrote:
> 
>> OK Now we start to read and write from osd-objects. We try to
>> collect at most contiguous pages as possible in a single write/read.
>> The first page index is the object's offset.
>>
>> TODO:
>>    In 64-bit a single bio can carry at most 128 pages.
>>    Add support of chaining multiple bios
>>
>>
>> ...
>>
>> +static int write_exec(struct page_collect *pcol)
>> +{
>> +	struct exofs_i_info *oi = exofs_i(pcol->inode);
>> +	struct osd_obj_id obj = {pcol->sbi->s_pid,
>> +					pcol->inode->i_ino + EXOFS_OBJ_OFF};
>> +	struct osd_request *or = NULL;
>> +	struct page_collect *pcol_copy = NULL;
>> +	loff_t i_start = pcol->pg_first << PAGE_CACHE_SHIFT;
> 
> bug.  On 32-bit this shift will overflow prior to getting promoted to
> 64-bit.  Do:
> 
> 	loff_t i_start = (loff_t)pcol->pg_first << PAGE_CACHE_SHIFT;
> 

In that case I might make pcol->pg_first loff_t.

Why is inode->i_index not an loff_t then?
Page-index <=> byte-offset, is done all the time 12 bits does not
make a difference.

>> ...
>>
>> +static int writepage_strip(struct page *page,
>> +			   struct writeback_control *wbc_unused, void *data)
> 
> Some of these functions could do with some comments explaining why they exist.
> 
>> +	struct page_collect *pcol = data;
>> +	struct inode *inode = pcol->inode;
>> +	struct exofs_i_info *oi = exofs_i(inode);
>> +	loff_t i_size = i_size_read(inode);
>> +	pgoff_t end_index = i_size >> PAGE_CACHE_SHIFT;
>> +	size_t len;
>> +	int ret;
>> +
>>
>> ...
>>
> 

Thanks
Boaz