From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rik van Riel Subject: Re: [PATCH 22/43] CacheFiles: Add a hook to write a single page of data to an inode [ver #46] Date: Thu, 02 Apr 2009 14:48:56 -0400 Message-ID: <49D50898.8020802@redhat.com> References: <20090401230321.28177.12010.stgit@warthog.procyon.org.uk> <20090401230515.28177.73948.stgit@warthog.procyon.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: viro@ZenIV.linux.org.uk, nfsv4@linux-nfs.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: David Howells Return-path: In-Reply-To: <20090401230515.28177.73948.stgit@warthog.procyon.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org David Howells wrote: > Add an address space operation to write one single page of data to an inode at > a page-aligned location (thus permitting the implementation to be highly > optimised). The data source is a single page. > > diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c > index b43b955..5d17070 100644 > --- a/fs/ext2/inode.c > +++ b/fs/ext2/inode.c > @@ -817,6 +817,8 @@ const struct address_space_operations ext2_nobh_aops = { > .direct_IO = ext2_direct_IO, > .writepages = ext2_writepages, > .migratepage = buffer_migrate_page, > + .write_one_page = generic_file_buffered_write_one_page, > + .write_one_page = generic_file_buffered_write_one_page Adding the same function pointer twice seems a bit excessive. Other than that, the patch looks good :)